Making sure the EnsureLoad method is not optimized away

StanleyGoldman · jcansdale · StanleyGoldman · commit 25878e087818 · 2019-06-04T11:24:56.000-04:00
co-authored-by: Jamie Cansdale &lt;jcansdale@gmail.com&gt;
diff --git a/src/GitHub.VisualStudio.16/CompositionServices.cs b/src/GitHub.VisualStudio.16/CompositionServices.cs
@@ -14,6 +14,7 @@
 using GitHub.VisualStudio.Settings;
 using GitHub.VisualStudio.Views;
 using GitHub.VisualStudio.Views.Dialog.Clone;
+using Microsoft;
 using Microsoft.VisualStudio.Shell;
 using Microsoft.VisualStudio.Threading;
 using Rothko;
@@ -139,6 +140,7 @@ static void InitializeViewLocator(IViewViewModelFactory viewViewModelFactory)
         static void EnsureLoaded(Type type)
         {
             // Ensure the containing assembly has been loaded
+            Assumes.NotNull(type);
         }
 
         static LoginManager CreateLoginManager(CompositionContainer compositionContainer)

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@`
`14`	`14`	`using GitHub.VisualStudio.Settings;`
`15`	`15`	`using GitHub.VisualStudio.Views;`
`16`	`16`	`using GitHub.VisualStudio.Views.Dialog.Clone;`
	`17`	`+using Microsoft;`
`17`	`18`	`using Microsoft.VisualStudio.Shell;`
`18`	`19`	`using Microsoft.VisualStudio.Threading;`
`19`	`20`	`using Rothko;`
`@@ -139,6 +140,7 @@ static void InitializeViewLocator(IViewViewModelFactory viewViewModelFactory)`
`139`	`140`	`static void EnsureLoaded(Type type)`
`140`	`141`	`{`
`141`	`142`	`// Ensure the containing assembly has been loaded`
	`143`	`+ Assumes.NotNull(type);`
`142`	`144`	`}`
`143`	`145`
`144`	`146`	`static LoginManager CreateLoginManager(CompositionContainer compositionContainer)`