Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 271c2cd

Browse files
Using only one view
1 parent c110ad9 commit 271c2cd

File tree

6 files changed

+1
-128
lines changed

6 files changed

+1
-128
lines changed

src/GitHub.InlineReviews/GitHub.InlineReviews.csproj

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,6 @@
102102
<Compile Include="Services\PullRequestSessionManager.cs" />
103103
<Compile Include="Margins\InlineCommentMarginProvider.cs" />
104104
<Compile Include="Services\PullRequestSessionService.cs" />
105-
<Compile Include="Tags\ShowInlineAnnotationGlyph.xaml.cs">
106-
<DependentUpon>ShowInlineAnnotationGlyph.xaml</DependentUpon>
107-
</Compile>
108-
<Compile Include="Tags\ShowInlineCommentAnnotationGlyph.xaml.cs">
109-
<DependentUpon>ShowInlineCommentAnnotationGlyph.xaml</DependentUpon>
110-
</Compile>
111105
<Compile Include="ViewModels\PullRequestFileMarginViewModel.cs" />
112106
<Compile Include="ViewModels\InlineCommentPeekViewModel.cs" />
113107
<Compile Include="ViewModels\PullRequestStatusViewModel.cs" />
@@ -414,14 +408,6 @@
414408
<SubType>Designer</SubType>
415409
<ContainsDesignTimeResources>true</ContainsDesignTimeResources>
416410
</Page>
417-
<Page Include="Tags\ShowInlineAnnotationGlyph.xaml">
418-
<Generator>MSBuild:Compile</Generator>
419-
<SubType>Designer</SubType>
420-
</Page>
421-
<Page Include="Tags\ShowInlineCommentAnnotationGlyph.xaml">
422-
<Generator>MSBuild:Compile</Generator>
423-
<SubType>Designer</SubType>
424-
</Page>
425411
<Page Include="Views\PullRequestFileMarginView.xaml">
426412
<SubType>Designer</SubType>
427413
<Generator>MSBuild:Compile</Generator>

src/GitHub.InlineReviews/Tags/InlineCommentGlyphFactory.cs

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -59,25 +59,7 @@ static UserControl CreateGlyph(InlineCommentTag tag)
5959

6060
if (showTag != null)
6161
{
62-
if (showTag.Thread != null && showTag.Annotations != null)
63-
{
64-
return new ShowInlineCommentAnnotationGlyph();
65-
}
66-
67-
if (showTag.Thread != null)
68-
{
69-
return new ShowInlineCommentGlyph
70-
{
71-
Opacity = showTag.Thread.IsStale ? 0.5 : 1,
72-
};
73-
}
74-
75-
if (showTag.Annotations != null)
76-
{
77-
return new ShowInlineAnnotationGlyph();
78-
}
79-
80-
throw new ArgumentException($"{nameof(showTag)} does not have a thread or annotations");
62+
return new ShowInlineCommentGlyph();
8163
}
8264

8365
throw new ArgumentException($"Unknown 'InlineCommentTag' type '{tag}'");

src/GitHub.InlineReviews/Tags/ShowInlineAnnotationGlyph.xaml

Lines changed: 0 additions & 33 deletions
This file was deleted.

src/GitHub.InlineReviews/Tags/ShowInlineAnnotationGlyph.xaml.cs

Lines changed: 0 additions & 14 deletions
This file was deleted.

src/GitHub.InlineReviews/Tags/ShowInlineCommentAnnotationGlyph.xaml

Lines changed: 0 additions & 34 deletions
This file was deleted.

src/GitHub.InlineReviews/Tags/ShowInlineCommentAnnotationGlyph.xaml.cs

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)