More backporting and cleaning

Author: StanleyGoldman

src/GitHub.App/SampleData/PullRequestDetailViewModelDesigner.cs

@@ -122,6 +122,7 @@ public PullRequestDetailViewModelDesigner()
         public ReactiveCommand<Unit> Checkout { get; }
         public ReactiveCommand<Unit> Pull { get; }
         public ReactiveCommand<Unit> Push { get; }
+        public ReactiveCommand<Unit> SyncSubmodules { get; }
         public ReactiveCommand<object> OpenOnGitHub { get; }
         public ReactiveCommand<object> ShowReview { get; }
         public ReactiveCommand<object> ShowAnnotations { get; }

src/GitHub.App/Services/FromGraphQlExtensions.cs

@@ -103,12 +103,10 @@ public static PullRequestReviewState FromGraphQl(this Octokit.GraphQL.Model.Pull
             }
         }
 
-        public static CheckAnnotationLevel? FromGraphQl(this Octokit.GraphQL.Model.CheckAnnotationLevel? value)
+        public static CheckAnnotationLevel FromGraphQl(this Octokit.GraphQL.Model.CheckAnnotationLevel value)
         {
             switch (value)
             {
-                case null:
-                    return null;
                 case Octokit.GraphQL.Model.CheckAnnotationLevel.Failure:
                     return CheckAnnotationLevel.Failure;
                 case Octokit.GraphQL.Model.CheckAnnotationLevel.Notice:

src/GitHub.Exports.Reactive/Models/IInlineAnnotationModel.cs

@@ -5,8 +5,19 @@
     /// </summary>
     public interface IInlineAnnotationModel
     {
+        /// <summary>
+        /// Gets the start line of the annotation.
+        /// </summary>
         int StartLine { get; }
+
+        /// <summary>
+        /// Gets the end line of the annotation.
+        /// </summary>
         int EndLine { get; }
+
+        /// <summary>
+        /// Gets the annotation level.
+        /// </summary>
         CheckAnnotationLevel AnnotationLevel { get; }
     }
 }

src/GitHub.Exports.Reactive/Models/InlineAnnotationModel.cs

@@ -2,11 +2,17 @@
 
 namespace GitHub.Models
 {
+    /// <inheritdoc />
     public class InlineAnnotationModel: IInlineAnnotationModel
     {
         private CheckRunModel checkRun;
         private CheckRunAnnotationModel annotation;
 
+        /// <summary>
+        /// Initializes the <see cref="InlineAnnotationModel"/>.
+        /// </summary>
+        /// <param name="checkRun">The check run model.</param>
+        /// <param name="annotation">The annotation model.</param>
         public InlineAnnotationModel(CheckRunModel checkRun, CheckRunAnnotationModel annotation)
         {
             Guard.ArgumentNotNull(annotation.AnnotationLevel, nameof(annotation.AnnotationLevel));
@@ -15,10 +21,13 @@ public InlineAnnotationModel(CheckRunModel checkRun, CheckRunAnnotationModel ann
             this.annotation = annotation;
         }
 
+        /// <inheritdoc />
         public int StartLine => annotation.StartLine;
 
+        /// <inheritdoc />
         public int EndLine => annotation.EndLine;
 
-        public CheckAnnotationLevel AnnotationLevel => annotation.AnnotationLevel.Value;
+        /// <inheritdoc />
+        public CheckAnnotationLevel AnnotationLevel => annotation.AnnotationLevel;
     }
 }

src/GitHub.Exports/Models/AnnotationModel.cs

@@ -33,6 +33,6 @@ public class CheckRunAnnotationModel
         /// <summary>
         /// The annotation's severity level.
         /// </summary>
-        public CheckAnnotationLevel? AnnotationLevel { get; set; }
+        public CheckAnnotationLevel AnnotationLevel { get; set; }
     }
 }

src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

@@ -108,7 +108,7 @@ public IReadOnlyList<IInlineAnnotationModel> BuildAnnotations(
                 ?.SelectMany(checkSuite => checkSuite.CheckRuns.Select(checkRun => new { checkSuite, checkRun}))
                 .SelectMany(arg =>
                     arg.checkRun.Annotations
-                        .Where(annotation => annotation.Path == relativePath && annotation.AnnotationLevel.HasValue)
+                        .Where(annotation => annotation.Path == relativePath)
                         .Select(annotation => new InlineAnnotationModel(arg.checkRun, annotation)))
                 .OrderBy(tuple => tuple.StartLine)
                 .ToArray();
@@ -789,9 +789,20 @@ async Task<LastCommitAdapter> GetPullRequestLastCommitAdapter(HostAddress addres
                                               {
                                                   Conclusion = run.Conclusion.FromGraphQl(),
                                                   Status = run.Status.FromGraphQl(),
+                                                  DatabaseId = run.DatabaseId.Value,
                                                   Name = run.Name,
                                                   DetailsUrl = run.Permalink,
                                                   Summary = run.Summary,
+                                                  Annotations = run.Annotations(null, null, null, null).AllPages()
+                                                      .Select(annotation => new CheckRunAnnotationModel
+                                                      {
+                                                          Title = annotation.Title,
+                                                          Message = annotation.Message,
+                                                          Path = annotation.Path,
+                                                          AnnotationLevel = annotation.AnnotationLevel.Value.FromGraphQl(),
+                                                          StartLine = annotation.Location.Start.Line,
+                                                          EndLine = annotation.Location.End.Line,
+                                                      }).ToList()
                                               }).ToList()
                                       }).ToList(),
                                   Statuses = commit.Commit.Status