Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 29bc2c6

Browse files
committed
Specify scheduler in ListenerCollectionTests too.
1 parent 1f2f591 commit 29bc2c6

File tree

2 files changed

+52
-34
lines changed

2 files changed

+52
-34
lines changed

test/TrackingCollectionTests/ListenerCollectionTests.cs

Lines changed: 51 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,70 @@
11
using System;
22
using System.Linq;
3+
using System.Reactive.Concurrency;
34
using System.Reactive.Linq;
45
using System.Reactive.Subjects;
56
using GitHub.Collections;
67
using NUnit.Framework;
8+
using ReactiveUI.Testing;
79

810
[TestFixture]
911
public class ListenerCollectionTests : TestBase
1012
{
1113
[Test]
1214
public void StickyItemShouldNotBePresentInitiallyWhereNoSelectionHasHappened()
1315
{
14-
var source = CreateSource();
15-
var stickie = new Thing();
16-
var selection = Observable.Empty<Thing>();
17-
var target = source.CreateListenerCollection(stickie, selection);
18-
19-
CollectionAssert.AreEqual(source, target);
16+
using (TestUtils.WithScheduler(Scheduler.CurrentThread))
17+
{
18+
var source = CreateSource();
19+
var stickie = new Thing();
20+
var selection = Observable.Empty<Thing>();
21+
var target = source.CreateListenerCollection(stickie, selection);
22+
23+
CollectionAssert.AreEqual(source, target);
24+
}
2025
}
2126

2227
[Test]
2328
public void StickyItemShouldNotBePresentAfterCreationWhenSelectionNull()
2429
{
25-
var source = CreateSource();
26-
var stickie = new Thing();
27-
var selection = Observable.Return<Thing>(null);
28-
var target = source.CreateListenerCollection(stickie, selection);
29-
30-
CollectionAssert.AreEqual(source, target);
30+
using (TestUtils.WithScheduler(Scheduler.CurrentThread))
31+
{
32+
var source = CreateSource();
33+
var stickie = new Thing();
34+
var selection = Observable.Return<Thing>(null);
35+
var target = source.CreateListenerCollection(stickie, selection);
36+
37+
CollectionAssert.AreEqual(source, target);
38+
}
3139
}
3240

3341
[Test]
3442
public void StickyItemShouldBePresentAfterCreationWhenSelectionNotNull()
3543
{
36-
var source = CreateSource();
37-
var stickie = new Thing();
38-
var selection = Observable.Return(source[0]);
39-
var target = source.CreateListenerCollection(stickie, selection);
40-
41-
var expected = new[] { stickie }.Concat(source);
42-
CollectionAssert.AreEqual(expected, target);
44+
using (TestUtils.WithScheduler(Scheduler.CurrentThread))
45+
{
46+
var source = CreateSource();
47+
var stickie = new Thing();
48+
var selection = Observable.Return(source[0]);
49+
var target = source.CreateListenerCollection(stickie, selection);
50+
51+
var expected = new[] { stickie }.Concat(source);
52+
CollectionAssert.AreEqual(expected, target);
53+
}
4354
}
4455

4556
[Test]
4657
public void StickyItemShouldNotBePresentAfterCreationWhenSelectionIsStickyItem()
4758
{
48-
var source = CreateSource();
49-
var stickie = new Thing();
50-
var selection = Observable.Return(stickie);
51-
var target = source.CreateListenerCollection(stickie, selection);
52-
53-
CollectionAssert.AreEqual(source, target);
59+
using (TestUtils.WithScheduler(Scheduler.CurrentThread))
60+
{
61+
var source = CreateSource();
62+
var stickie = new Thing();
63+
var selection = Observable.Return(stickie);
64+
var target = source.CreateListenerCollection(stickie, selection);
65+
66+
CollectionAssert.AreEqual(source, target);
67+
}
5468
}
5569

5670
[Test]
@@ -115,15 +129,18 @@ public void StickyItemShouldBeRemovedWhenSelectionChangesToStickyItem()
115129
[Test]
116130
public void ResetingTrackingCollectionWorks()
117131
{
118-
var source = CreateSource();
119-
var stickie = new Thing();
120-
var selection = new ReplaySubject<Thing>();
121-
var target = source.CreateListenerCollection(stickie, selection);
122-
selection.OnNext(stickie);
123-
selection.OnNext(null);
124-
CollectionAssert.AreEqual(source, target);
125-
source.Filter = (a,b,c) => true;
126-
CollectionAssert.AreEqual(source, target);
132+
using (TestUtils.WithScheduler(Scheduler.CurrentThread))
133+
{
134+
var source = CreateSource();
135+
var stickie = new Thing();
136+
var selection = new ReplaySubject<Thing>();
137+
var target = source.CreateListenerCollection(stickie, selection);
138+
selection.OnNext(stickie);
139+
selection.OnNext(null);
140+
CollectionAssert.AreEqual(source, target);
141+
source.Filter = (a, b, c) => true;
142+
CollectionAssert.AreEqual(source, target);
143+
}
127144
}
128145

129146
TrackingCollection<Thing> CreateSource()

test/TrackingCollectionTests/TrackingCollectionTests.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
<ItemGroup>
1111
<ProjectReference Include="..\..\src\GitHub.Exports.Reactive\GitHub.Exports.Reactive.csproj" />
12+
<ProjectReference Include="..\..\submodules\reactiveui\src\ReactiveUI.Testing\ReactiveUI.Testing.csproj" />
1213
</ItemGroup>
1314

1415
<ItemGroup>

0 commit comments

Comments
 (0)