Merge pull request #2138 from github/fixes/stale-global-suppressions

Remove stale global suppressions

Author: StanleyGoldman

src/GitHub.Exports.Reactive/GlobalSuppressions.cs

@@ -12,11 +12,11 @@ public interface IGitHubServiceProvider : IServiceProvider
         IServiceProvider GitServiceProvider { get; set; }
 
         T GetService<T>() where T : class;
-        Ret GetService<T, Ret>() where T : class
-                                 where Ret : class;
+        TRet GetService<T, TRet>() where T : class
+                                 where TRet : class;
 
         object TryGetService(Type t);
-        object TryGetService(string typename);
+        object TryGetService(string typeName);
         T TryGetService<T>() where T : class;
 
         void AddService(Type t, object owner, object instance);

src/GitHub.Exports/Services/IGitHubServiceProvider.cs

@@ -1,8 +1,10 @@
 using System;
 using System.Windows.Input;
+using System.Diagnostics.CodeAnalysis;
 
 namespace GitHub.Services
 {
+    [SuppressMessage("Microsoft.Performance", "CA1815:OverrideEqualsAndOperatorEqualsOnValueTypes")]
     public struct Notification
     {
         public enum NotificationType

src/GitHub.Exports/Services/INotificationDispatcher.cs

@@ -1,11 +1,9 @@
 using System;
 using System.Diagnostics.CodeAnalysis;
-using System.Reactive.Disposables;
 using System.Reactive.Linq;
 using System.Windows;
 using System.Windows.Controls;
 using System.Windows.Media;
-using GitHub.Extensions;
 using GitHub.Extensions.Reactive;
 using ReactiveUI;
 using ReactiveUI.Legacy;
@@ -14,7 +12,10 @@ namespace GitHub.UI
 {
     public class UserErrorMessages : UserControl
     {
+        [SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields")]
         readonly IDisposable whenAnyShowingMessage;
+
+        [SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields")]
         readonly IDisposable whenAnyDataContext;
 
         public UserErrorMessages()
@@ -34,7 +35,7 @@ public UserErrorMessages()
                 });
         }
 
-        public static readonly DependencyProperty IconMarginProperty = DependencyProperty.Register("IconMargin", typeof(Thickness), typeof(UserErrorMessages), new PropertyMetadata(new Thickness(0,0,8,0)));
+        public static readonly DependencyProperty IconMarginProperty = DependencyProperty.Register("IconMargin", typeof(Thickness), typeof(UserErrorMessages), new PropertyMetadata(new Thickness(0, 0, 8, 0)));
         public Thickness IconMargin
         {
             get { return (Thickness)GetValue(IconMarginProperty); }

src/GitHub.UI.Reactive/Controls/Validation/UserErrorMessages.cs

@@ -10,3 +10,4 @@
 [assembly: SuppressMessage("Usage", "VSTHRD101:Avoid unsupported async delegates")]
 [assembly: SuppressMessage("Usage", "VSTHRD110:Observe result of async calls")]
 [assembly: SuppressMessage("Style", "VSTHRD200:Use \"Async\" suffix for async methods")]
+[assembly: SuppressMessage("Reliability", "VSSDK006:Check services exist")]