Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 2c6303a

Browse files
Rename CheckRunId to Id for the win
1 parent ca27920 commit 2c6303a

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/GitHub.App/ViewModels/GitHubPane/PullRequestAnnotationsViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ void Load(PullRequestDetailModel pullRequest)
118118
var checkSuiteRun = pullRequest
119119
.CheckSuites.SelectMany(checkSuite => checkSuite.CheckRuns
120120
.Select(checkRun => new{checkSuite, checkRun}))
121-
.First(arg => arg.checkRun.CheckRunId == CheckRunId);
121+
.First(arg => arg.checkRun.Id == CheckRunId);
122122

123123
CheckSuiteName = checkSuiteRun.checkSuite.ApplicationName;
124124
CheckRunName = checkSuiteRun.checkRun.Name;

src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public static IEnumerable<IPullRequestCheckViewModel> Build(IViewViewModelFactor
9494

9595
var pullRequestCheckViewModel = (PullRequestCheckViewModel)viewViewModelFactory.CreateViewModel<IPullRequestCheckViewModel>();
9696
pullRequestCheckViewModel.CheckType = PullRequestCheckType.ChecksApi;
97-
pullRequestCheckViewModel.CheckRunId = checkRunModel.CheckRunId;
97+
pullRequestCheckViewModel.CheckRunId = checkRunModel.Id;
9898
pullRequestCheckViewModel.HasAnnotations = checkRunModel.Annotations?.Any() ?? false;
9999
pullRequestCheckViewModel.Title = checkRunModel.Name;
100100
pullRequestCheckViewModel.Description = checkRunModel.Summary;

src/GitHub.Exports/Models/CheckRunModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@ public class CheckRunModel
4646
/// <summary>
4747
/// The database id of a Check Run.
4848
/// </summary>
49-
public string CheckRunId { get; set; }
49+
public string Id { get; set; }
5050
}
5151
}

src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -787,7 +787,7 @@ async Task<LastCommitAdapter> GetPullRequestLastCommitAdapter(HostAddress addres
787787
CheckRuns = suite.CheckRuns(null, null, null, null, null).AllPages(10)
788788
.Select(run => new CheckRunModel
789789
{
790-
CheckRunId = run.Id.Value,
790+
Id = run.Id.Value,
791791
Conclusion = run.Conclusion.FromGraphQl(),
792792
Status = run.Status.FromGraphQl(),
793793
Name = run.Name,

0 commit comments

Comments
 (0)