Add IsProductComponent/IsExperimental properties

Decouple IsExperimental from Debug/Release configurations.
Update README.md with description of build flavors.

Author: jcansdale

README.md

@@ -54,6 +54,42 @@ install.cmd
 
 Note, the script will only install in one instance of Visual Studio 2017 (Enterprise, Professional or Community).
 
+## Build Flavors
+
+By default, building will create a VSIX with `Experimental="true"` and `AllUsers="false"` in its `extension.vsixmanifest`. These settings are necessary in order to easily install a standalone VSIX file. There is no need to uninstall the version previously installed via Visual Studio setup / Extensions and Updates.
+
+To build and install a `Debug` configuration VSIX:
+```txt
+build.cmd
+install.cmd
+```
+
+To build and install a `Release` configuration VSIX:
+```txt
+set Configuration=Release
+build.cmd
+install.cmd
+```
+
+To build a VSIX that could be deployed via the gallery / Extensions and Updates:
+```txt
+set Configuration=Release
+set IsExperimental=false
+build.cmd
+install.cmd
+```
+
+To build a VSIX that could be deployed via Visual Studio setup:
+```txt
+set Configuration=Release
+set IsExperimental=false
+set IsProductComponent=false
+build.cmd
+install.cmd
+```
+
+Note, attempting to install `IsExperimental=false` builds of the VSIX is not recommended.
+
 ## More information
 
 - Andreia Gaita's [presentation](https://www.youtube.com/watch?v=hz2hCO8e_8w) at Codemania 2016 about this extension.

build.cmd

@@ -1,6 +1,8 @@
-@if "%config%" == "" set config=Debug
+@if "%Configuration%" == "" set Configuration=Debug
+@if "%IsExperimental%" == "" set IsExperimental=true
+@if "%IsProductComponent%" == "" set IsProductComponent=false
 
 call "%ProgramFiles(x86)%\Microsoft Visual Studio 14.0\Common7\Tools\VsDevCmd.bat"
 
-@rem Build the GitHub.VisualStudio project / VSIX file
-msbuild GitHubVS.sln /p:Configuration=%Config% /t:GitHub_VisualStudio /p:IsProductComponent=false
+msbuild GitHubVS.sln /t:GitHub_VisualStudio /p:Configuration=%Configuration% /p:IsExperimental=%IsExperimental% /p:IsProductComponent=%IsProductComponent%
+@echo Built GitHub.VisualStudio with Configuration=%Configuration% IsExperimental=%IsExperimental% IsProductComponent=%IsProductComponent%

install.cmd

@@ -1,6 +1,6 @@
-@if "%config%" == "" set config=Debug
+@if "%Configuration%" == "" set Configuration=Debug
 
 @set path=%cd%\tools\VsixUtil;%path%
 
-@echo Installing `%config%` build of GitHub for Visual Studio
-vsixutil /install "%cd%\build\%config%\GitHub.VisualStudio.vsix" /s Enterprise;Professional;Community
+vsixutil /install "%cd%\build\%Configuration%\GitHub.VisualStudio.vsix" /s Enterprise;Professional;Community
+@echo Installed %Configuration% build of GitHub for Visual Studio

src/GitHub.VisualStudio/GitHub.VisualStudio.csproj

@@ -3,10 +3,9 @@
   <Import Project="..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.23-pre\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props" Condition="Exists('..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.23-pre\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props')" />
   <Import Project="..\..\packages\LibGit2Sharp.NativeBinaries.1.0.129\build\LibGit2Sharp.NativeBinaries.props" Condition="Exists('..\..\packages\LibGit2Sharp.NativeBinaries.1.0.129\build\LibGit2Sharp.NativeBinaries.props')" />
   <!--
-  Update 'Release' configurations to have AllUsers="true" and Experimental="false"
-  The 'Debug' configuration will keep AllUsers="false" and Experimental="true".
+  Update to have AllUsers="true" and Experimental="false" when $(IsExperimental)' == 'false'
   -->
-  <Target Name="MakeVsixManifestAllUsers" AfterTargets="DetokenizeVsixManifestFile" Condition=" '$(Configuration)' == 'Release' ">
+  <Target Name="MakeVsixManifestAllUsers" AfterTargets="DetokenizeVsixManifestFile" Condition=" '$(IsExperimental)' == 'false' ">
     <Warning Text="NOTE: Tweaking '$(IntermediateVsixManifest)' to have AllUsers='true' and Experimental='false'" />
     <XmlPoke XmlInputPath="$(IntermediateVsixManifest)" Query="/x:PackageManifest/x:Installation/@AllUsers" Value="true" Namespaces="&lt;Namespace Prefix='x' Uri='http://schemas.microsoft.com/developer/vsx-schema/2011' /&gt;" />
     <XmlPoke XmlInputPath="$(IntermediateVsixManifest)" Query="/x:PackageManifest/x:Installation/@Experimental" Value="false" Namespaces="&lt;Namespace Prefix='x' Uri='http://schemas.microsoft.com/developer/vsx-schema/2011' /&gt;" />
@@ -444,7 +443,9 @@
     </VSCTCompile>
   </ItemGroup>
   <ItemGroup>
-    <Resource Include="FodyWeavers.xml" />
+    <Resource Include="FodyWeavers.xml">
+      <SubType>Designer</SubType>
+    </Resource>
     <CodeAnalysisDictionary Include="..\common\CodeAnalysisDictionary.xml">
       <Link>Properties\CodeAnalysisDictionary.xml</Link>
     </CodeAnalysisDictionary>