GitHub Pane view and viewmodel

Add a view and viewmodel for the GitHubPane. They'll handle hosting the
views for specific features (pull request list, pull request creation,
detail, etc), as well as loading and navigating between them, using a
long-lived instance of UIController. Toolbar commands are controlled by
the view model.

The view model gets informed of contextual repository changes in the
same way that sections and navigation items do - by hooking up to
TeamExplorerServiceHolder (via the constructor) and getting
notifications. These notifications are now also sent via property
events, as well as `RepoChanged()` calls.

Author: shana

src/GitHub.Exports/Exports/ExportMetadata.cs

@@ -17,8 +17,9 @@ public enum UIViewType {
 		Clone,
         Publish,
         End = 100,
-        Finished
-	}
+        Finished,
+        GitHubPane,
+    }
 
     [MetadataAttribute]
     [AttributeUsage(AttributeTargets.Class, AllowMultiple=false)]

src/GitHub.Exports/GitHub.Exports.csproj

@@ -125,6 +125,7 @@
   <ItemGroup>
     <Compile Include="Authentication\AuthenticationResultExtensions.cs" />
     <Compile Include="Extensions\VSExtensions.cs" />
+    <Compile Include="ViewModels\IServiceProviderAware.cs" />
     <Compile Include="UI\IView.cs" />
     <Compile Include="UI\Octicon.cs" />
     <Compile Include="ViewModels\IGitHubConnectSection.cs" />
@@ -145,6 +146,7 @@
     <Compile Include="Services\IUIProvider.cs" />
     <Compile Include="Services\IWikiProbe.cs" />
     <Compile Include="Services\WikiProbe.cs" />
+    <Compile Include="ViewModels\IGitHubPaneViewModel.cs" />
     <Compile Include="ViewModels\ILoginViewModel.cs" />
     <Compile Include="Primitives\HostAddress.cs" />
     <Compile Include="UI\IUIController.cs" />

src/GitHub.Exports/ViewModels/IGitHubPaneViewModel.cs

@@ -0,0 +1,9 @@
+using System.Windows.Input;
+
+namespace GitHub.ViewModels
+{
+    public interface IGitHubPaneViewModel : IViewModel
+    {
+        string ActiveRepoName { get; }
+    }
+}

src/GitHub.Exports/ViewModels/IServiceProviderAware.cs

@@ -0,0 +1,9 @@
+using System;
+
+namespace GitHub.ViewModels
+{
+    public interface IServiceProviderAware
+    {
+        void Initialize(IServiceProvider serviceProvider);
+    }
+}

src/GitHub.VisualStudio/Base/TeamExplorerGitRepoInfo.cs

@@ -1,6 +1,7 @@
 using GitHub.Models;
 using GitHub.Primitives;
 using GitHub.Services;
+using GitHub.VisualStudio.Helpers;
 using Microsoft.VisualStudio.TeamFoundation.Git.Extensibility;
 using NullGuard;
 
@@ -10,7 +11,9 @@ public class TeamExplorerGitRepoInfo : TeamExplorerBase, IGitAwareItem
     {
         public TeamExplorerGitRepoInfo()
         {
-            ActiveRepo = null;
+            activeRepo = null;
+            activeRepoUri = null;
+            activeRepoName = string.Empty;
         }
 
         ISimpleRepositoryModel activeRepo;
@@ -24,14 +27,26 @@ public ISimpleRepositoryModel ActiveRepo
                 ActiveRepoName = string.Empty;
                 ActiveRepoUri = null;
                 activeRepo = value;
+                this.RaisePropertyChange();
             }
         }
 
+        UriString activeRepoUri;
         /// <summary>
         /// Represents the web URL of the repository on GitHub.com, even if the origin is an SSH address.
         /// </summary>
         [AllowNull]
-        public UriString ActiveRepoUri { [return: AllowNull] get; set; }
-        public string ActiveRepoName { get; set; }
+        public UriString ActiveRepoUri
+        {
+            [return: AllowNull] get { return activeRepoUri; }
+            set { activeRepoUri = value; this.RaisePropertyChange(); }
+        }
+
+        string activeRepoName;
+        public string ActiveRepoName
+        {
+            get { return activeRepoName; }
+            set { activeRepoName = value; this.RaisePropertyChange(); }
+        }
     }
 }

src/GitHub.VisualStudio/Base/TeamExplorerItemBase.cs

@@ -31,6 +31,11 @@ public ISimpleApiClient SimpleApiClient
 
         protected ISimpleApiClientFactory ApiFactory => apiFactory;
 
+        public TeamExplorerItemBase(ITeamExplorerServiceHolder holder)
+        {
+            this.holder = holder;
+        }
+
         public TeamExplorerItemBase(ISimpleApiClientFactory apiFactory, ITeamExplorerServiceHolder holder)
         {
             this.apiFactory = apiFactory;

src/GitHub.VisualStudio/Base/TeamExplorerSectionBase.cs

@@ -4,15 +4,13 @@
 using NullGuard;
 using GitHub.Services;
 using System.Diagnostics;
-using System.Threading;
-using GitHub.Extensions;
-using Microsoft.VisualStudio.TeamFoundation.Git.Extensibility;
 using GitHub.Api;
 using GitHub.Models;
+using GitHub.ViewModels;
 
 namespace GitHub.VisualStudio.Base
 {
-    public class TeamExplorerSectionBase : TeamExplorerItemBase, ITeamExplorerSection
+    public class TeamExplorerSectionBase : TeamExplorerItemBase, ITeamExplorerSection, IServiceProviderAware
     {
         protected IConnectionManager connectionManager;
 
@@ -52,6 +50,14 @@ public virtual object GetExtensibilityService(Type serviceType)
             return null;
         }
 
+        public TeamExplorerSectionBase(ITeamExplorerServiceHolder holder)
+            : base(holder)
+        {
+            IsVisible = false;
+            IsEnabled = true;
+            IsExpanded = true;
+        }
+
         public TeamExplorerSectionBase(ISimpleApiClientFactory apiFactory, ITeamExplorerServiceHolder holder)
             : base(apiFactory, holder)
         {
@@ -60,29 +66,39 @@ public TeamExplorerSectionBase(ISimpleApiClientFactory apiFactory, ITeamExplorer
             IsExpanded = true;
         }
 
+        public TeamExplorerSectionBase(ITeamExplorerServiceHolder holder, IConnectionManager cm) : this(holder)
+        {
+            connectionManager = cm;
+        }
+
         public TeamExplorerSectionBase(ISimpleApiClientFactory apiFactory, ITeamExplorerServiceHolder holder,
             IConnectionManager cm) : this(apiFactory, holder)
         {
             connectionManager = cm;
         }
 
-        public virtual void Cancel()
+        void ITeamExplorerSection.Cancel()
+        {
+        }
+
+        void ITeamExplorerSection.Initialize(object sender, SectionInitializeEventArgs e)
         {
+            Initialize(e.ServiceProvider);
         }
 
-        public virtual void Initialize(object sender, SectionInitializeEventArgs e)
+        public virtual void Initialize(IServiceProvider serviceProvider)
         {
 #if DEBUG
-//            VsOutputLogger.WriteLine("{0:HHmmssff}\t{1} Initialize", DateTime.Now, GetType());
+            //VsOutputLogger.WriteLine("{0:HHmmssff}\t{1} Initialize", DateTime.Now, GetType());
 #endif
-            ServiceProvider = e.ServiceProvider;
+            ServiceProvider = serviceProvider;
             Debug.Assert(holder != null, "Could not get an instance of TeamExplorerServiceHolder");
             if (holder == null)
                 return;
-            holder.ServiceProvider = e.ServiceProvider;
+            holder.ServiceProvider = ServiceProvider;
             SubscribeToRepoChanges();
 #if DEBUG
-//            VsOutputLogger.WriteLine("{0:HHmmssff}\t{1} Initialize DONE", DateTime.Now, GetType());
+            //VsOutputLogger.WriteLine("{0:HHmmssff}\t{1} Initialize DONE", DateTime.Now, GetType());
 #endif
         }
 

src/GitHub.VisualStudio/GitHub.VisualStudio.csproj

@@ -274,6 +274,9 @@
     <Compile Include="UI\Views\Controls\TwoFactorControl.xaml.cs">
       <DependentUpon>TwoFactorControl.xaml</DependentUpon>
     </Compile>
+    <Compile Include="UI\Views\GitHubPaneView.xaml.cs">
+      <DependentUpon>GitHubPaneView.xaml</DependentUpon>
+    </Compile>
     <Compile Include="UI\WindowController.xaml.cs">
       <DependentUpon>WindowController.xaml</DependentUpon>
     </Compile>
@@ -391,6 +394,10 @@
       <SubType>
       </SubType>
     </Page>
+    <Page Include="UI\Views\GitHubPaneView.xaml">
+      <SubType>Designer</SubType>
+      <Generator>MSBuild:Compile</Generator>
+    </Page>
     <Page Include="UI\WindowController.xaml">
       <Generator>MSBuild:Compile</Generator>
     </Page>

src/GitHub.VisualStudio/SharedDictionary.xaml

@@ -1,52 +1,60 @@
-<ResourceDictionary
-    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
-    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
-    xmlns:PresentationOptions="http://schemas.microsoft.com/winfx/2006/xaml/presentation/options"
->
+<ResourceDictionary 
+  xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
+  xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+  xmlns:PresentationOptions="http://schemas.microsoft.com/winfx/2006/xaml/presentation/options">
 
   <ResourceDictionary.MergedDictionaries>
     <ResourceDictionary Source="pack://application:,,,/GitHub.VisualStudio;component/UI/Views/Controls/ActionLinkButton.xaml" />
   </ResourceDictionary.MergedDictionaries>
 
-  <Style x:Key="VSStyledButton" TargetType="{x:Type Button}" BasedOn="{StaticResource VsButtonStyleKey}">
-  </Style>
+  <Style x:Key="VSStyledButton" BasedOn="{StaticResource VsButtonStyleKey}" TargetType="{x:Type Button}" />
   <Style x:Key="VSStyledCheckBox" BasedOn="{StaticResource VsCheckBoxStyleKey}" TargetType="{x:Type CheckBox}">
     <Setter Property="Foreground" Value="{DynamicResource VsBrush.ToolWindowText}" />
     <Setter Property="Background" Value="{DynamicResource VsBrush.ToolWindowBackground}" />
     <Style.Triggers>
       <Trigger Property="UIElement.IsMouseOver" Value="true">
-        <Setter Property="Background" Value="{DynamicResource VsBrush.ToolWindowBackground}"/>
+        <Setter Property="Background" Value="{DynamicResource VsBrush.ToolWindowBackground}" />
       </Trigger>
     </Style.Triggers>
   </Style>
-  <Style x:Key="VSStyledComboBox" TargetType="{x:Type ComboBox}" BasedOn="{StaticResource VsComboBoxStyleKey}">
-  </Style>
-  
+  <Style x:Key="VSStyledComboBox" BasedOn="{StaticResource VsComboBoxStyleKey}" TargetType="{x:Type ComboBox}" />
+
   <DrawingBrush x:Key="ConnectArrowBrush">
     <DrawingBrush.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing Brush="{DynamicResource VsBrush.ControlLinkText}"
-                            Geometry="F1 M 9,11 L 7,11 9,9 4,9 4,7 9,7 7,5 9,5 12,8 Z"/>
-          <GeometryDrawing Brush="{DynamicResource VsBrush.ControlLinkText}"
-                            Geometry="F1 M 7.9741,1.0698 C 4.1461,1.0698 1.0441,4.1728 1.0441,7.9998 1.0441,11.8268 4.1461,14.9298 7.9741,14.9298 11.8011,14.9298 14.9041,11.8268 14.9041,7.9998 14.9041,4.1728 11.8011,1.0698 7.9741,1.0698 M 7.9741,2.0598 C 11.2501,2.0598 13.9151,4.7248 13.9151,7.9998 13.9151,11.2758 11.2501,13.9408 7.9741,13.9408 4.6991,13.9408 2.0341,11.2758 2.0341,7.9998 2.0341,4.7248 4.6991,2.0598 7.9741,2.0598 "/>
+          <GeometryDrawing Brush="{DynamicResource VsBrush.ControlLinkText}" Geometry="F1 M 9,11 L 7,11 9,9 4,9 4,7 9,7 7,5 9,5 12,8 Z" />
+          <GeometryDrawing Brush="{DynamicResource VsBrush.ControlLinkText}" Geometry="F1 M 7.9741,1.0698 C 4.1461,1.0698 1.0441,4.1728 1.0441,7.9998 1.0441,11.8268 4.1461,14.9298 7.9741,14.9298 11.8011,14.9298 14.9041,11.8268 14.9041,7.9998 14.9041,4.1728 11.8011,1.0698 7.9741,1.0698 M 7.9741,2.0598 C 11.2501,2.0598 13.9151,4.7248 13.9151,7.9998 13.9151,11.2758 11.2501,13.9408 7.9741,13.9408 4.6991,13.9408 2.0341,11.2758 2.0341,7.9998 2.0341,4.7248 4.6991,2.0598 7.9741,2.0598 " />
         </DrawingGroup.Children>
       </DrawingGroup>
     </DrawingBrush.Drawing>
   </DrawingBrush>
 
-  <Style x:Key="VerticalSeparator" TargetType="{x:Type Separator}">
-    <Setter Property="Control.Background" Value="{DynamicResource VsBrush.GrayText}" />
-    <Setter Property="FrameworkElement.Margin" Value="3,0,3,0" />
-    <Setter Property="UIElement.Focusable" Value="False" />
-    <Setter Property="Control.Template">
+  <Style x:Key="TitleVerticalSeparator" TargetType="{x:Type Separator}">
+    <Setter Property="Foreground" Value="#BBBBBB" />
+    <Setter Property="Width" Value="2" />
+    <Setter Property="Margin" Value="3,0,3,0" />
+    <Setter Property="Template">
       <Setter.Value>
         <ControlTemplate TargetType="{x:Type Separator}">
-          <Border SnapsToDevicePixels="True" Width="1" Background="{TemplateBinding Control.Background}"
-                      BorderBrush="{TemplateBinding Control.BorderBrush}" BorderThickness="{TemplateBinding Control.BorderThickness}" />
+          <Border Width="{TemplateBinding Width}"
+                  Background="{TemplateBinding Foreground}"
+                  BorderBrush="{TemplateBinding Foreground}"
+                  BorderThickness="{TemplateBinding BorderThickness}"
+                  SnapsToDevicePixels="True" />
         </ControlTemplate>
       </Setter.Value>
     </Setter>
   </Style>
 
+  <Style x:Key="VerticalSeparator" TargetType="{x:Type Separator}">
+    <Setter Property="Background" Value="Gray" />
+    <Setter Property="Margin" Value="3,0,3,0" />
+    <Setter Property="LayoutTransform">
+      <Setter.Value>
+        <RotateTransform Angle="90" />
+      </Setter.Value>
+    </Setter>
+  </Style>
+
 </ResourceDictionary>

src/GitHub.VisualStudio/TeamExplorer/Connect/GitHubConnectSection.cs

@@ -159,9 +159,9 @@ public override void Refresh()
             base.Refresh();
         }
 
-        public override void Initialize(object sender, SectionInitializeEventArgs e)
+        public override void Initialize(IServiceProvider serviceProvider)
         {
-            base.Initialize(sender, e);
+            base.Initialize(serviceProvider);
             UpdateConnection();
 
             // watch for new repos added to the local repo list