Fix tests

Author: shana

src/GitHub.Exports/Models/SimpleRepositoryModel.cs

@@ -64,15 +64,18 @@ public void Refresh()
         /// <returns>An UriString with the generated url, or null if the repository has no remote server configured or if it can't be found locally</returns>
         public UriString GenerateUrl(string path = null, int startLine = -1, int endLine = -1)
         {
-            var sha = HeadSha;
-            if (CloneUrl == null || String.IsNullOrEmpty(sha))
+            if (CloneUrl == null)
                 return null;
 
+            var sha = HeadSha;
+            // this also incidentally checks whether the repo has a valid LocalPath
+            if (String.IsNullOrEmpty(sha))
+                return CloneUrl.ToRepositoryUrl().AbsoluteUri;
+
             if (path != null && Path.IsPathRooted(path))
             {
                 // if the path root doesn't match the repository local path, then ignore it
-                if (LocalPath == null ||
-                    !path.StartsWith(LocalPath, StringComparison.OrdinalIgnoreCase))
+                if (!path.StartsWith(LocalPath, StringComparison.OrdinalIgnoreCase))
                 {
                     Debug.Assert(false, String.Format(CultureInfo.CurrentCulture, "GenerateUrl: path {0} doesn't match repository {1}", path, LocalPath));
                     path = null;
@@ -81,7 +84,7 @@ public UriString GenerateUrl(string path = null, int startLine = -1, int endLine
                     path = path.Substring(LocalPath.Length + 1);
             }
 
-            return new UriString(GenerateUrl(cloneUrl.ToRepositoryUrl().AbsoluteUri, sha, path, startLine, endLine));
+            return new UriString(GenerateUrl(CloneUrl.ToRepositoryUrl().AbsoluteUri, sha, path, startLine, endLine));
         }
 
         const string CommitFormat = "{0}/commit/{1}";

src/UnitTests/GitHub.Exports/SimpleRepositoryModelTests.cs

@@ -40,6 +40,7 @@ void SetupRepository(string sha)
     [InlineData(true, "https://github.com/foo/bar", "123123", @"src\dir\file1.cs", -1, 2, "https://github.com/foo/bar/blob/123123/src/dir/file1.cs")]
     [InlineData(true, "https://github.com/foo/bar", "", @"src\dir\file1.cs", -1, 2, "https://github.com/foo/bar")]
     [InlineData(true, null, "123123", @"src\dir\file1.cs", 1, 2, null)]
+    [InlineData(false, "[email protected]/foo/bar", "123123", @"src\dir\file1.cs", -1, -1, "https://github.com/foo/bar/blob/123123/src/dir/file1.cs")]
     public void GenerateUrl(bool createRootedPath, string baseUrl, string sha, string path, int startLine, int endLine, string expected)
     {
         SetupRepository(sha);