Fix dispose pattern

donokuda · donokuda · commit 3244589bfe17 · 2016-05-06T13:40:38.000-07:00
diff --git a/src/GitHub.VisualStudio/UI/Views/GitHubPaneViewModel.cs b/src/GitHub.VisualStudio/UI/Views/GitHubPaneViewModel.cs
@@ -294,11 +294,12 @@ protected override void Dispose(bool disposing)
         {
             if (disposing)
             {
-                if (disposed)
-                    return;
-                disposed = true;
-                DisableButtons();
-                disposables.Dispose();
+                if (!disposed)
+                {
+                    disposed = true;
+                    DisableButtons();
+                    disposables.Dispose();
+                }
             }
             base.Dispose(disposing);
         }

Original file line number	Diff line number	Diff line change
`@@ -294,11 +294,12 @@ protected override void Dispose(bool disposing)`
`294`	`294`	`{`
`295`	`295`	`if (disposing)`
`296`	`296`	`{`
`297`		`- if (disposed)`
`298`		`- return;`
`299`		`- disposed = true;`
`300`		`- DisableButtons();`
`301`		`- disposables.Dispose();`
	`297`	`+ if (!disposed)`
	`298`	`+ {`
	`299`	`+ disposed = true;`
	`300`	`+ DisableButtons();`
	`301`	`+ disposables.Dispose();`
	`302`	`+ }`
`302`	`303`	`}`
`303`	`304`	`base.Dispose(disposing);`
`304`	`305`	`}`