Fix all the things!

Add a tracker class to accurately track the state of the local git
repository list, so we can update our lists accordingly. Cleanup and fix
a bunch of list-refreshing stuff.

Author: shana

src/GitHub.App/SampleData/SampleViewModels.cs

@@ -211,6 +211,10 @@ public IObservable<IConnection> Login()
             public void Logout()
             {
             }
+
+            public void Dispose()
+            {
+            }
         }
 
         public RepositoryPublishViewModelDesigner()
@@ -572,8 +576,9 @@ public void Login()
         {
         }
 
-        public void OpenRepository()
+        public bool OpenRepository()
         {
+            return true;
         }
 
         public IConnection SectionConnection { get; }

src/GitHub.Exports/Models/IConnection.cs

@@ -6,7 +6,7 @@
 
 namespace GitHub.Models
 {
-    public interface IConnection
+    public interface IConnection : IDisposable
     {
         HostAddress HostAddress { get; }
         string Username { get; }

src/GitHub.Exports/Models/IConnectionManager.cs

@@ -19,6 +19,6 @@ public interface IConnectionManager
         // for telling IRepositoryHosts that we need to login from cache
         [SuppressMessage("Microsoft.Design", "CA1009:DeclareEventHandlersCorrectly")]
         event Func<IConnection, IObservable<IConnection>> DoLogin;
-        void RefreshRepositories(IVSServices services);
+        void RefreshRepositories();
     }
 }

src/GitHub.Exports/Services/Connection.cs

@@ -32,5 +32,25 @@ public void Logout()
         {
             manager.RequestLogout(this);
         }
+
+        #region IDisposable Support
+        private bool disposed = false; // To detect redundant calls
+
+        protected virtual void Dispose(bool disposing)
+        {
+            if (!disposed)
+            {
+                if (disposing)
+                    Repositories.Clear();
+                disposed = true;
+            }
+        }
+
+        public void Dispose()
+        {
+            Dispose(true);
+            GC.SuppressFinalize(this);
+        }
+        #endregion
     }
 }

src/GitHub.Exports/ViewModels/IGitHubConnectSection.cs

@@ -9,7 +9,7 @@ public interface IGitHubConnectSection
         void DoClone();
         void SignOut();
         void Login();
-        void OpenRepository();
+        bool OpenRepository();
         IConnection SectionConnection { get; }
     }
 }

src/GitHub.VisualStudio/Services/ConnectionManager.cs

@@ -27,6 +27,7 @@ class ConnectionCacheItem
     public class ConnectionManager : IConnectionManager
     {
         readonly string cachePath;
+        readonly IVSServices vsServices;
         const string cacheFile = "ghfvs.connections";
 
         public event Func<IConnection, IObservable<IConnection>> DoLogin;
@@ -39,8 +40,9 @@ public class ConnectionManager : IConnectionManager
         Action<string> dirCreate;
 
         [ImportingConstructor]
-        public ConnectionManager(IProgram program)
+        public ConnectionManager(IProgram program, IVSServices services)
         {
+            vsServices = services;
             fileExists = (path) => System.IO.File.Exists(path);
             readAllText = (path, encoding) => System.IO.File.ReadAllText(path, encoding);
             writeAllText = (path, content) => System.IO.File.WriteAllText(path, content);
@@ -59,8 +61,9 @@ public ConnectionManager(IProgram program)
             Connections.CollectionChanged += RefreshConnections;
         }
 
-        public ConnectionManager(IProgram program, Rothko.IOperatingSystem os)
+        public ConnectionManager(IProgram program, Rothko.IOperatingSystem os, IVSServices services)
         {
+            vsServices = services;
             fileExists = (path) => os.File.Exists(path);
             readAllText = (path, encoding) => os.File.ReadAllText(path, encoding);
             writeAllText = (path, content) => os.File.WriteAllText(path, content);
@@ -106,7 +109,7 @@ public bool RemoveConnection(HostAddress address)
             var c = Connections.FirstOrDefault(x => x.HostAddress.Equals(address));
             if (c == null)
                 return false;
-            Connections.Remove(c);
+            RequestLogout(c);
             return true;
         }
 
@@ -123,10 +126,8 @@ public void RequestLogout(IConnection connection)
             Connections.Remove(connection);
         }
 
-        public void RefreshRepositories(IVSServices services)
+        public void RefreshRepositories()
         {
-            var list = services.GetKnownRepositories();
-            list.GroupBy(r => Connections.FirstOrDefault(c => c.HostAddress == HostAddress.Create(r.CloneUrl)))
             var list = vsServices.GetKnownRepositories();
             list.GroupBy(r => Connections.FirstOrDefault(c => c.HostAddress.Equals(HostAddress.Create(r.CloneUrl))))
                 .Where(g => g.Key != null)
@@ -148,13 +149,12 @@ void RefreshConnections(object sender, System.Collections.Specialized.NotifyColl
         {
             if (e.Action == System.Collections.Specialized.NotifyCollectionChangedAction.Remove)
             {
-                // RepositoryHosts hasn't been loaded so it can't handle logging out, we have to do it ourselves
-                if (DoLogin == null)
+                foreach (IConnection c in e.OldItems)
                 {
-                    foreach (IConnection c in e.OldItems)
-                    {
+                    // RepositoryHosts hasn't been loaded so it can't handle logging out, we have to do it ourselves
+                    if (DoLogin == null)
                         Api.SimpleCredentialStore.RemoveCredentials(c.HostAddress.CredentialCacheKeyHost);
-                    }
+                    c.Dispose();
                 }
             }
             SaveConnectionsToCache();