Fixes for code analysis

Author: StanleyGoldman

src/GitHub.InlineReviews/Tags/ShowInlineCommentTag.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using GitHub.Extensions;
 using GitHub.Models;
 using GitHub.Services;
@@ -27,8 +28,8 @@ public ShowInlineCommentTag(IPullRequestSession session, int lineNumber, DiffCha
         public IInlineCommentThreadModel Thread { get; set; }
 
         /// <summary>
-        /// Gets an array of models holding details of the annotations at the tagged line.
+        /// Gets a list of models holding details of the annotations at the tagged line.
         /// </summary>
-        public IInlineAnnotationModel[] Annotations { get; set; }
+        public IReadOnlyList<IInlineAnnotationModel> Annotations { get; set; }
     }
 }

test/GitHub.InlineReviews.UnitTests/Tags/InlineCommentTaggerTests.cs

@@ -279,7 +279,7 @@ public void ShouldReturnShowInlineTagForAnnotation()
                 Assert.That(showInlineTag, Is.Not.Null);
                 Assert.That(showInlineTag.Thread, Is.Null);
                 Assert.That(showInlineTag.Annotations, Is.Not.Null);
-                Assert.That(showInlineTag.Annotations.Length, Is.EqualTo(1));
+                Assert.That(showInlineTag.Annotations.Count, Is.EqualTo(1));
             }
 
             [Test]
@@ -302,7 +302,7 @@ public void ShouldReturnShowInlineTagForTwoAnnotations()
                 Assert.That(showInlineTag, Is.Not.Null);
                 Assert.That(showInlineTag.Thread, Is.Null);
                 Assert.That(showInlineTag.Annotations, Is.Not.Null);
-                Assert.That(showInlineTag.Annotations.Length, Is.EqualTo(2));
+                Assert.That(showInlineTag.Annotations.Count, Is.EqualTo(2));
             }
 
             [Test]
@@ -325,7 +325,7 @@ public void ShouldReturnShowOneInlineTagForCommentAndAnnotation()
                 Assert.That(showInlineTag, Is.Not.Null);
                 Assert.That(showInlineTag.Thread, Is.Not.Null);
                 Assert.That(showInlineTag.Annotations, Is.Not.Null);
-                Assert.That(showInlineTag.Annotations.Length, Is.EqualTo(1));
+                Assert.That(showInlineTag.Annotations.Count, Is.EqualTo(1));
             }
 
             [Test]