Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 3765f64

Browse files
committed
No blowing up, show error instead
1 parent 29897f3 commit 3765f64

File tree

3 files changed

+17
-0
lines changed

3 files changed

+17
-0
lines changed

src/GitHub.App/Resources.Designer.cs

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/GitHub.App/Resources.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,9 @@
153153
<data name="PublishToTitle" xml:space="preserve">
154154
<value>Publish repository to {0}</value>
155155
</data>
156+
<data name="RepositoryCloneFailedNoSelectedRepo" xml:space="preserve">
157+
<value>No selected repository.</value>
158+
</data>
156159
<data name="RepositoryCreationFailedAlreadyExists" xml:space="preserve">
157160
<value>Repository '{0}/{1}' already exists.</value>
158161
</data>

src/GitHub.App/ViewModels/RepositoryCloneViewModel.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,11 @@ IObservable<Unit> OnCloneRepository(object state)
120120
{
121121
var repository = SelectedRepository;
122122
Debug.Assert(repository != null, "Should not be able to attempt to clone a repo when it's null");
123+
if (repository == null)
124+
{
125+
notificationService.ShowError(Resources.RepositoryCloneFailedNoSelectedRepo);
126+
return Observable.Return(Unit.Default);
127+
}
123128
// The following is a noop if the directory already exists.
124129
operatingSystem.Directory.CreateDirectory(BaseRepositoryPath);
125130
return cloneService.CloneRepository(repository.CloneUrl, repository.Name, BaseRepositoryPath);

0 commit comments

Comments
 (0)