Merge pull request #1129 from github/fixes/1098-upgrade-octokit

Update octokit to 0.24.0.

Author: grokys

src/GitHub.Api/SimpleApiClient.cs

@@ -133,7 +133,7 @@ async Task<bool> IsEnterpriseInternal()
                 return false;
 #endif
             var ret = await probe.ProbeAsync(HostAddress.WebUri);
-            return (ret == EnterpriseProbeResult.Ok);
+            return (ret == Services.EnterpriseProbeResult.Ok);
         }
     }
 }

src/GitHub.App/Api/ApiClient.cs

@@ -77,7 +77,7 @@ public IObservable<PullRequestReviewComment> CreatePullRequestReviewComment(
             Guard.ArgumentNotEmptyString(path, nameof(path));
 
             var comment = new PullRequestReviewCommentCreate(body, commitId, path, position);
-            return gitHubClient.PullRequest.Comment.Create(owner, name, number, comment);
+            return gitHubClient.PullRequest.ReviewComment.Create(owner, name, number, comment);
         }
 
         public IObservable<PullRequestReviewComment> CreatePullRequestReviewComment(
@@ -88,7 +88,7 @@ public IObservable<PullRequestReviewComment> CreatePullRequestReviewComment(
             int inReplyTo)
         {
             var comment = new PullRequestReviewCommentReplyCreate(body, inReplyTo);
-            return gitHubClient.PullRequest.Comment.CreateReply(owner, name, number, comment);
+            return gitHubClient.PullRequest.ReviewComment.CreateReply(owner, name, number, comment);
         }
 
         public IObservable<Gist> CreateGist(NewGist newGist)
@@ -303,7 +303,7 @@ public IObservable<PullRequestReviewComment> GetPullRequestReviewComments(string
             Guard.ArgumentNotEmptyString(owner, nameof(owner));
             Guard.ArgumentNotEmptyString(name, nameof(name));
 
-            return gitHubClient.PullRequest.Comment.GetAll(owner, name, number);
+            return gitHubClient.PullRequest.ReviewComment.GetAll(owner, name, number);
         }
 
         public IObservable<PullRequest> GetPullRequestsForRepository(string owner, string name)

src/UnitTests/GitHub.Api/SimpleApiClientTests.cs

@@ -6,6 +6,7 @@
 using NSubstitute;
 using Octokit;
 using Xunit;
+using EnterpriseProbeResult = GitHub.Services.EnterpriseProbeResult;
 
 public class SimpleApiClientTests
 {
@@ -240,6 +241,6 @@ private static Repository CreateRepository(int id, bool hasWiki)
         return new Repository("", "", "", "", "", "", "",
             id, new User(), "", "", "", "", "", false, false, 0, 0, "",
             0, null, DateTimeOffset.Now, DateTimeOffset.Now, new RepositoryPermissions(), null, null, false,
-            hasWiki, false);
+            hasWiki, false, false, 0, 0, null, null, null);
     }
 }

src/UnitTests/Helpers/TestBaseClass.cs

@@ -51,7 +51,7 @@ protected static Repository CreateRepository(string owner, string name, string d
             id, CreateOctokitUser(owner),
             name, "fullname", "description", notCloneUrl, "c#", false, parent != null, 0, 0, "master",
             0, DateTimeOffset.UtcNow, DateTimeOffset.UtcNow, DateTimeOffset.UtcNow,
-            new RepositoryPermissions(), parent, null, true, false, false);
+            new RepositoryPermissions(), parent, null, true, false, false, false, 0, 0, null, null, null);
     }
 
     protected static PullRequest CreatePullRequest(User user, int id, ItemState state, string title,
@@ -64,13 +64,15 @@ protected static PullRequest CreatePullRequest(User user, int id, ItemState stat
             false, false, 0, 0, "master",
             0, null, createdAt, updatedAt,
             null, null, null,
-            false, false, false);
-        return new PullRequest(uri, uri, uri, uri, uri, uri,
+            false, false, false,
+            false, 0, 0,
+            null, null, null);
+        return new PullRequest(0, uri, uri, uri, uri, uri, uri,
             id, state, title, "", createdAt, updatedAt,
             null, null, 
             new GitReference(uri.ToString(), "foo:bar", "bar", "123", user, repo),
             new GitReference(uri.ToString(), "foo:baz", "baz", "123", user, repo),
-            user, null, false, null,
+            user, null, null, false, null,
             commentCount, reviewCommentCount, 0, 0, 0, 0,
             null, false);
     }