Rename Treeish to TreeishPath

GitHub URLs combine branches/SHAs and tree paths.

For example:
https://github.com/github/visualstudio/tree/master/src

Git would represent "master/src" as the tree-ish "master:src". Because
looking at the URL we don't know where the branch stops and the tree
starts, "master/src" is being stored as the TreeishPath property.

Author: jcansdale

src/GitHub.App/Services/GitHubContext.cs

@@ -8,7 +8,10 @@ public class GitHubContext
         public string RepositoryName { get; set; }
         public string Host { get; set; }
         public string BranchName { get; set; }
-        public string Treeish { get; set; }
+        /// <summary>
+        /// Like a tree-ish but with ':' changed to '/' (e.g. "master/src" not "master:src").
+        /// </summary>
+        public string TreeishPath { get; set; }
         public string BlobName { get; set; }
         public int? PullRequest { get; set; }
         public int? Issue { get; set; }

src/GitHub.App/Services/GitHubContextService.cs

@@ -91,7 +91,7 @@ public GitHubContext FindContextFromUrl(string url)
             var match = urlBlobRegex.Match(subpath);
             if (match.Success)
             {
-                context.Treeish = match.Groups["treeish"].Value;
+                context.TreeishPath = match.Groups["treeish"].Value;
                 context.BlobName = match.Groups["blobName"].Value;
                 return context;
             }
@@ -155,7 +155,7 @@ public GitHubContext FindContextFromWindowTitle(string windowTitle)
                     Owner = match.Groups["owner"].Value,
                     RepositoryName = match.Groups["repo"].Value,
                     BranchName = match.Groups["branch"].Value,
-                    Treeish = $"{match.Groups["branch"].Value}/{match.Groups["tree"].Value}"
+                    TreeishPath = $"{match.Groups["branch"].Value}/{match.Groups["tree"].Value}"
                 };
             }
 
@@ -266,7 +266,7 @@ public bool TryOpenFile(GitHubContext context, string repositoryDir)
 
         public string ResolvePath(GitHubContext context)
         {
-            var treeish = context.Treeish;
+            var treeish = context.TreeishPath;
             if (treeish == null)
             {
                 return null;

test/GitHub.App.UnitTests/Services/GitHubContextServiceTests.cs

@@ -69,13 +69,13 @@ public void PullRequest(string url, int? expectPullRequest)
         [TestCase("https://github.com/github/VisualStudio/blob/ee863ce265fc6217f589e66766125fed1b5b8256/foo.cs", "ee863ce265fc6217f589e66766125fed1b5b8256", "foo.cs")]
         [TestCase("https://github.com/github/VisualStudio/blob/ee863ce265fc6217f589e66766125fed1b5b8256/path/foo.cs", "ee863ce265fc6217f589e66766125fed1b5b8256/path", "foo.cs")]
         [TestCase("https://github.com/github/VisualStudio/blob/master/bar.cs#stuff", "master", "bar.cs")]
-        public void Blob(string url, string expectTreeish, string expectBlobName)
+        public void Blob(string url, string expectTreeishPath, string expectBlobName)
         {
             var target = CreateGitHubContextService();
 
             var context = target.FindContextFromUrl(url);
 
-            Assert.That(context.Treeish, Is.EqualTo(expectTreeish));
+            Assert.That(context.TreeishPath, Is.EqualTo(expectTreeishPath));
             Assert.That(context.BlobName, Is.EqualTo(expectBlobName));
         }
 
@@ -302,7 +302,7 @@ public void Tree(string windowTitle, string expectTreeish, string expectBranch)
 
             var context = target.FindContextFromWindowTitle(windowTitle);
 
-            Assert.That(context?.Treeish, Is.EqualTo(expectTreeish));
+            Assert.That(context?.TreeishPath, Is.EqualTo(expectTreeish));
             Assert.That(context?.BranchName, Is.EqualTo(expectBranch));
         }