Fix other calls to CloneRepository

The wrong overload was being used in some cases.

Author: jcansdale

src/GitHub.App/Services/RepositoryCreationService.cs

@@ -1,4 +1,5 @@
 using System;
+using System.IO;
 using System.ComponentModel.Composition;
 using System.Reactive;
 using System.Reactive.Linq;
@@ -36,7 +37,7 @@ public IObservable<Unit> CreateRepository(
             Guard.ArgumentNotEmptyString(directory, nameof(directory));
 
             return apiClient.CreateRepository(newRepository, account.Login, account.IsUser)
-                .Select(repository => cloneService.CloneRepository(repository.CloneUrl, repository.Name, directory))
+                .Select(repository => cloneService.CloneRepository(repository.CloneUrl, Path.Combine(directory, repository.Name)))
                 .SelectUnit();
         }
     }

src/GitHub.VisualStudio/Commands/OpenFromUrlCommand.cs

@@ -94,7 +94,7 @@ public override async Task Execute(string url)
                 switch (result)
                 {
                     case VSConstants.MessageBoxResult.IDYES:
-                        await repositoryCloneService.Value.CloneRepository(cloneUrl, repositoryDirName, targetDir);
+                        await repositoryCloneService.Value.CloneRepository(cloneUrl, repositoryDir);
                         // Open the cloned repository
                         dte.Value.ExecuteCommand("File.OpenFolder", repositoryDir);
                         dte.Value.ExecuteCommand("View.TfsTeamExplorer");

test/GitHub.App.UnitTests/Services/RepositoryCloneServiceTests.cs

@@ -37,7 +37,7 @@ public async Task UpdatesMetricsWhenRepositoryClonedAsync()
             var usageTracker = Substitute.For<IUsageTracker>();
             var cloneService = new RepositoryCloneService(operatingSystem, vsGitServices, graphqlFactory, usageTracker);
 
-            await cloneService.CloneRepository("https://github.com/foo/bar", "bar", @"c:\dev");
+            await cloneService.CloneRepository("https://github.com/foo/bar", @"c:\dev\bar");
             var model = UsageModel.Create(Guid.NewGuid());
 
             await usageTracker.Received().IncrementCounter(