Make InUIThread return false on non-UIThread

jcansdale · jcansdale · commit 4040e13fe5db · 2018-03-12T14:15:16.000Z
Was always returning true when not InUnitTestRunner.
diff --git a/src/GitHub.Exports/Helpers/ThreadingHelper.cs b/src/GitHub.Exports/Helpers/ThreadingHelper.cs
@@ -24,7 +24,7 @@ public interface IAwaiter : INotifyCompletion
 
     public static class ThreadingHelper
     {
-        public static bool InUIThread => (!Guard.InUnitTestRunner && Application.Current.Dispatcher.CheckAccess()) || !(Guard.InUnitTestRunner);
+        public static bool InUIThread => Guard.InUnitTestRunner ? true : Application.Current.Dispatcher.CheckAccess();
 
         /// <summary>
         /// Gets the Dispatcher for the main thread.
@@ -88,7 +88,7 @@ public AwaiterWrapper()
             {
                 isCompleted = () => true;
                 onCompleted = c => c();
-                getResult = () => {};
+                getResult = () => { };
             }
 
             public AwaiterWrapper(MainThreadAwaiter awaiter)

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public interface IAwaiter : INotifyCompletion`
`24`	`24`
`25`	`25`	`public static class ThreadingHelper`
`26`	`26`	`{`
`27`		`- public static bool InUIThread => (!Guard.InUnitTestRunner && Application.Current.Dispatcher.CheckAccess()) \|\| !(Guard.InUnitTestRunner);`
	`27`	`+ public static bool InUIThread => Guard.InUnitTestRunner ? true : Application.Current.Dispatcher.CheckAccess();`
`28`	`28`
`29`	`29`	`/// <summary>`
`30`	`30`	`/// Gets the Dispatcher for the main thread.`
`@@ -88,7 +88,7 @@ public AwaiterWrapper()`
`88`	`88`	`{`
`89`	`89`	`isCompleted = () => true;`
`90`	`90`	`onCompleted = c => c();`
`91`		`- getResult = () => {};`
	`91`	`+ getResult = () => { };`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`public AwaiterWrapper(MainThreadAwaiter awaiter)`