Avoid firing StatusChanged if we're not on a repo

Author: jcansdale

src/GitHub.App/Services/TeamExplorerContext.cs

@@ -127,9 +127,9 @@ async Task RefreshAsync()
                         log.Debug("Fire StatusChanged event when PullRequest changes for ActiveRepository");
                         StatusChanged?.Invoke(this, EventArgs.Empty);
                     }
-                    else
+                    else if (newRepositoryPath != null)
                     {
-                        log.Debug("Fire StatusChanged event when ***anything*** changes");
+                        log.Debug("Fire StatusChanged event when on a repository and anything changes");
                         StatusChanged?.Invoke(this, EventArgs.Empty);
                     }
 

test/GitHub.App.UnitTests/Services/TeamExplorerContextTests.cs

@@ -151,14 +151,13 @@ public void NoActiveRepositoryChange_SolutionChanges()
 
         public class TheStatusChangedEvent
         {
-            [TestCase(true, false)]
-            [TestCase(false, true)]
-            public void AlwaysFireWhenNoLocalPathChange(bool changePath, bool expectWasRaised)
+            [TestCase("path", "path", true)]
+            [TestCase("path1", "path2", false)]
+            [TestCase(null, null, false)]
+            public void AlwaysFireWhenNoLocalPathChange(string path1, string path2, bool expectWasRaised)
             {
                 var gitExt = CreateGitExt();
                 var repositoryPaths = new[] { Directory.GetCurrentDirectory(), Path.GetTempPath() };
-                var path1 = Directory.GetCurrentDirectory();
-                var path2 = changePath ? Path.GetTempPath() : path1;
                 var repoInfo1 = CreateRepositoryModel(path1);
                 var repoInfo2 = CreateRepositoryModel(path2);