Make VSGitExtFactory non-static factory class

Author: jcansdale

src/GitHub.VisualStudio/GitHubPackage.cs

@@ -256,7 +256,7 @@ async Task<object> CreateService(IAsyncServiceContainer container, CancellationT
             else if (serviceType == typeof(IVSGitExt))
             {
                 var vsVersion = ApplicationInfo.GetHostVersionInfo().FileMajorPart;
-                return VSGitExtFactory.Create(vsVersion, this);
+                return new VSGitExtFactory(vsVersion, this).Create();
             }
             else if (serviceType == typeof(IGitHubToolWindowManager))
             {

src/GitHub.VisualStudio/Services/VSGitExtFactory.cs

@@ -14,14 +14,23 @@ public class VSGitExtFactory
     {
         static readonly ILogger log = LogManager.ForContext<VSGitExtFactory>();
 
-        public static IVSGitExt Create(int vsVersion, IAsyncServiceProvider sp)
+        readonly int vsVersion;
+        readonly IAsyncServiceProvider asyncServiceProvider;
+
+        public VSGitExtFactory(int vsVersion, IAsyncServiceProvider asyncServiceProvider)
+        {
+            this.vsVersion = vsVersion;
+            this.asyncServiceProvider = asyncServiceProvider;
+        }
+
+        public IVSGitExt Create()
         {
             switch (vsVersion)
             {
                 case 14:
-                    return Create(() => new VSGitExt14(sp));
+                    return Create(() => new VSGitExt14(asyncServiceProvider));
                 case 15:
-                    return Create(() => new VSGitExt15(sp));
+                    return Create(() => new VSGitExt15(asyncServiceProvider));
                 default:
                     log.Error("There is no IVSGitExt implementation for DTE version {Version}", vsVersion);
                     return null;