Pass Lazy services into CreateGistCommand

jcansdale · jcansdale · commit 494dfeb2f92f · 2018-03-14T10:53:00.000Z
No need to manually construct Lazy loading using GetService.
diff --git a/src/GitHub.VisualStudio/Commands/CreateGistCommand.cs b/src/GitHub.VisualStudio/Commands/CreateGistCommand.cs
@@ -18,11 +18,11 @@ public class CreateGistCommand : VsCommand, ICreateGistCommand
         readonly Lazy<ISelectedTextProvider> selectedTextProvider;
 
         [ImportingConstructor]
-        protected CreateGistCommand(IGitHubServiceProvider serviceProvider)
+        protected CreateGistCommand(Lazy<IDialogService> dialogService, Lazy<ISelectedTextProvider> selectedTextProvider)
             : base(CommandSet, CommandId)
         {
-            dialogService = new Lazy<IDialogService>(() => serviceProvider.TryGetService<IDialogService>());
-            selectedTextProvider = new Lazy<ISelectedTextProvider>(() => serviceProvider.TryGetService<ISelectedTextProvider>());
+            this.dialogService = dialogService;
+            this.selectedTextProvider = selectedTextProvider;
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -18,11 +18,11 @@ public class CreateGistCommand : VsCommand, ICreateGistCommand`
`18`	`18`	`readonly Lazy<ISelectedTextProvider> selectedTextProvider;`
`19`	`19`
`20`	`20`	`[ImportingConstructor]`
`21`		`- protected CreateGistCommand(IGitHubServiceProvider serviceProvider)`
	`21`	`+ protected CreateGistCommand(Lazy<IDialogService> dialogService, Lazy<ISelectedTextProvider> selectedTextProvider)`
`22`	`22`	`: base(CommandSet, CommandId)`
`23`	`23`	`{`
`24`		`- dialogService = new Lazy<IDialogService>(() => serviceProvider.TryGetService<IDialogService>());`
`25`		`- selectedTextProvider = new Lazy<ISelectedTextProvider>(() => serviceProvider.TryGetService<ISelectedTextProvider>());`
	`24`	`+ this.dialogService = dialogService;`
	`25`	`+ this.selectedTextProvider = selectedTextProvider;`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`/// <summary>`