Fix reacting to new repos on the list

If the user is logged out and clicks Create or Clone, they'll go through
the login dialog and the repository list will get populated as soon as
that's done, before the actual create/clone action starts. We don't want
to handle those "new" repos on the list as if they've just been
cloned/created.

Author: shana

src/GitHub.Exports/Exports/ExportMetadata.cs

@@ -2,6 +2,8 @@
 using System.ComponentModel.Composition;
 using GitHub.UI;
 using GitHub.ViewModels;
+using System.Windows.Controls;
+using System.Linq;
 
 namespace GitHub.Exports {
 
@@ -42,4 +44,12 @@ public interface IViewModelMetadata
     {
         UIViewType ViewType { get; }
     }
+
+    public static class ExportViewAttributeExtensions
+    {
+        public static bool IsViewType(this UserControl c, UIViewType type)
+        {
+            return c.GetType().GetCustomAttributesData().Any(x => x.AttributeType.Equals(typeof(ExportViewAttribute)) && (UIViewType)x.NamedArguments[0].TypedValue.Value == type);
+        }
+    }
 }

src/GitHub.Exports/Services/IUIProvider.cs

@@ -2,6 +2,7 @@
 using System.ComponentModel.Composition.Hosting;
 using GitHub.Models;
 using GitHub.UI;
+using System.Windows.Controls;
 
 namespace GitHub.Services
 {
@@ -20,7 +21,7 @@ public interface IUIProvider
         void AddService(Type t, object instance);
         void RemoveService(Type t);
 
-        IObservable<object> SetupUI(UIControllerFlow controllerFlow, IConnection connection);
+        IObservable<UserControl> SetupUI(UIControllerFlow controllerFlow, IConnection connection);
         void RunUI();
         void RunUI(UIControllerFlow controllerFlow, IConnection connection);
     }

src/GitHub.VisualStudio/Services/UIProvider.cs

@@ -17,6 +17,7 @@
 using NLog;
 using System.Reactive.Linq;
 using GitHub.Infrastructure;
+using System.Windows.Controls;
 
 namespace GitHub.VisualStudio
 {
@@ -184,12 +185,12 @@ public void RemoveService(Type t)
         }
 
         UI.WindowController windowController;
-        public IObservable<object> SetupUI(UIControllerFlow controllerFlow, [AllowNull] IConnection connection)
+        public IObservable<UserControl> SetupUI(UIControllerFlow controllerFlow, [AllowNull] IConnection connection)
         {
             if (!Initialized)
             {
                 log.Error("ExportProvider is not initialized, cannot setup UI.");
-                return Observable.Return<object>(null);
+                return Observable.Return<UserControl>(null);
             }
 
             StopUI();

src/GitHub.VisualStudio/TeamExplorer/Connect/GitHubConnectSection.cs

@@ -16,6 +16,7 @@
 using System.Windows.Data;
 using System.ComponentModel;
 using ReactiveUI;
+using GitHub.Exports;
 
 namespace GitHub.VisualStudio.TeamExplorer.Connect
 {
@@ -227,13 +228,11 @@ void RefreshRepositories()
 
         public void DoCreate()
         {
-            isCreating = true;
             StartFlow(UIControllerFlow.Create);
         }
 
         public void DoClone()
         {
-            isCloning = true;
             StartFlow(UIControllerFlow.Clone);
         }
 
@@ -272,7 +271,15 @@ void StartFlow(UIControllerFlow controllerFlow)
         {
             var uiProvider = ServiceProvider.GetExportedValue<IUIProvider>();
             uiProvider.GitServiceProvider = ServiceProvider;
-            uiProvider.RunUI(controllerFlow, SectionConnection);
+            var ret = uiProvider.SetupUI(controllerFlow, SectionConnection);
+            ret.Subscribe((c) =>
+            {
+                if (c.IsViewType(UIViewType.Clone))
+                    isCloning = true;
+                else if (c.IsViewType(UIViewType.Create))
+                    isCreating = true;
+            });
+            uiProvider.RunUI();
         }
 
         bool disposed;