Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 4bed92e

Browse files
committed
Explicitely dispose subscriptions
1 parent ef00200 commit 4bed92e

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/GitHub.App/Controllers/UIController.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -160,22 +160,22 @@ void SetupView(UIViewType viewType, IView view)
160160
var dvm = factory.GetViewModel(UIViewType.TwoFactor);
161161
disposables.Add(dvm);
162162
var twofa = dvm.Value;
163-
twofa.WhenAny(x => x.IsShowing, x => x.Value)
163+
disposables.Add(twofa.WhenAny(x => x.IsShowing, x => x.Value)
164164
.Where(x => x)
165165
.ObserveOn(RxApp.MainThreadScheduler)
166-
.Subscribe(_ => Fire(Trigger.Next));
166+
.Subscribe(_ => Fire(Trigger.Next)));
167167

168-
view.Done
168+
disposables.Add(view.Done
169169
.ObserveOn(RxApp.MainThreadScheduler)
170-
.Subscribe(_ => Fire(Trigger.Finish));
170+
.Subscribe(_ => Fire(Trigger.Finish)));
171171
}
172172
else if (viewType != UIViewType.TwoFactor)
173173
{
174-
view.Done
174+
disposables.Add(view.Done
175175
.ObserveOn(RxApp.MainThreadScheduler)
176-
.Subscribe(_ => Fire(Trigger.Next));
176+
.Subscribe(_ => Fire(Trigger.Next)));
177177
}
178-
view.Cancel.Subscribe(_ => Stop());
178+
disposables.Add(view.Cancel.Subscribe(_ => Stop()));
179179
}
180180

181181
IView CreateViewAndViewModel(UIViewType viewType)

0 commit comments

Comments
 (0)