Add tests for PR creation service and view model

Author: shana

src/UnitTests/GitHub.App/Services/PullRequestServiceTests.cs

@@ -0,0 +1,48 @@
+using System.Reactive.Linq;
+using System.Threading.Tasks;
+using NSubstitute;
+using Xunit;
+using UnitTests;
+using GitHub.Models;
+using System;
+using GitHub.Services;
+
+public class PullRequestServiceTests : TestBaseClass
+{
+    [Fact]
+    public async Task CreatePullRequestAllArgsMandatory()
+    {
+        var serviceProvider = Substitutes.ServiceProvider;
+        var service = new PullRequestService();
+
+        IRepositoryHost host = null;
+        ISimpleRepositoryModel repository = null;
+        string title = null;
+        string body = null;
+        IBranch source = null;
+        IBranch target = null;
+
+        Assert.Throws<ArgumentNullException>(() => service.CreatePullRequest(host, repository, title, body, source, target));
+
+        host = serviceProvider.GetRepositoryHosts().GitHubHost;
+        Assert.Throws<ArgumentNullException>(() => service.CreatePullRequest(host, repository, title, body, source, target));
+
+        repository = new SimpleRepositoryModel("name", new GitHub.Primitives.UriString("http://github.com/github/stuff"));
+        Assert.Throws<ArgumentNullException>(() => service.CreatePullRequest(host, repository, title, body, source, target));
+
+        title = "a title";
+        Assert.Throws<ArgumentNullException>(() => service.CreatePullRequest(host, repository, title, body, source, target));
+
+        body = "a body";
+        Assert.Throws<ArgumentNullException>(() => service.CreatePullRequest(host, repository, title, body, source, target));
+
+        source = new BranchModel() { Name = "source" };
+        Assert.Throws<ArgumentNullException>(() => service.CreatePullRequest(host, repository, title, body, source, target));
+
+        target = new BranchModel() { Name = "target" };
+        var pr = await service.CreatePullRequest(host, repository, title, body, source, target);
+
+        Assert.NotNull(pr);
+    }
+
+}

src/UnitTests/GitHub.App/ViewModels/PullRequestCreationViewModelTests.cs

@@ -0,0 +1,36 @@
+using System.Reactive.Linq;
+using System.Threading.Tasks;
+using NSubstitute;
+using Xunit;
+using UnitTests;
+using GitHub.Models;
+using System;
+using GitHub.Services;
+using GitHub.ViewModels;
+
+public class PullRequestCreationViewModelTests : TempFileBaseClass
+{
+    [Fact]
+    public async Task NullDescriptionBecomesEmptyBody()
+    {
+        var serviceProvider = Substitutes.ServiceProvider;
+        var service = new PullRequestService();
+        var notifications = Substitute.For<INotificationService>();
+
+        var host = serviceProvider.GetRepositoryHosts().GitHubHost;
+        var ms = Substitute.For<IModelService>();
+        host.ModelService.Returns(ms);
+
+        var repository = new SimpleRepositoryModel("name", new GitHub.Primitives.UriString("http://github.com/github/stuff"));
+        var title = "a title";
+
+        var vm = new PullRequestCreationViewModel(host, repository, service, notifications);
+        vm.SourceBranch = new BranchModel() { Name = "source" };
+        vm.TargetBranch = new BranchModel() { Name = "target" };
+        vm.PRTitle = title;
+
+        await vm.CreatePullRequest.ExecuteAsync();
+        ms.Received().CreatePullRequest(repository, vm.PRTitle, String.Empty, vm.SourceBranch, vm.TargetBranch);
+    }
+
+}

src/UnitTests/Substitutes.cs

@@ -2,6 +2,7 @@
 using GitHub.Authentication;
 using GitHub.Models;
 using GitHub.Services;
+using GitHub.VisualStudio;
 using Microsoft.VisualStudio.ComponentModelHost;
 using NSubstitute;
 using Rothko;
@@ -65,6 +66,7 @@ public static IOperatingSystem OperatingSystem
         public static IConnectionManager ConnectionManager { get { return Substitute.For<IConnectionManager>(); } }
         public static ITwoFactorChallengeHandler TwoFactorChallengeHandler { get { return Substitute.For<ITwoFactorChallengeHandler>(); } }
         public static IGistPublishService GistPublishService { get { return Substitute.For<IGistPublishService>(); } }
+        public static IPullRequestService PullRequestService { get { return Substitute.For<IPullRequestService>(); } }
 
         /// <summary>
         /// This returns a service provider with everything mocked except for 
@@ -127,6 +129,7 @@ public static IServiceProvider GetServiceProvider(
             ret.GetService(typeof(IAvatarProvider)).Returns(avatarProvider);
             ret.GetService(typeof(ITwoFactorChallengeHandler)).Returns(TwoFactorChallengeHandler);
             ret.GetService(typeof(IGistPublishService)).Returns(GistPublishService);
+            ret.GetService(typeof(IPullRequestService)).Returns(PullRequestService);
             return ret;
         }
 
@@ -198,5 +201,10 @@ public static IGistPublishService GetGistPublishService(this IServiceProvider pr
         {
             return provider.GetService(typeof(IGistPublishService)) as IGistPublishService;
         }
+
+        public static IPullRequestService GetPullRequestsService(this IServiceProvider provider)
+        {
+            return provider.GetService(typeof(IPullRequestService)) as IPullRequestService;
+        }
     }
 }

src/UnitTests/UnitTests.csproj

@@ -166,11 +166,13 @@
     <Compile Include="GitHub.App\Models\RepositoryModelTests.cs" />
     <Compile Include="GitHub.App\Services\AvatarProviderTests.cs" />
     <Compile Include="GitHub.App\Services\GitClientTests.cs" />
+    <Compile Include="GitHub.App\Services\PullRequestServiceTests.cs" />
     <Compile Include="GitHub.App\Services\RepositoryCloneServiceTests.cs" />
     <Compile Include="GitHub.App\Services\RepositoryCreationServiceTests.cs" />
     <Compile Include="GitHub.App\ViewModels\GistCreationViewModelTests.cs" />
     <Compile Include="GitHub.App\ViewModels\LoginControlViewModelTests.cs" />
     <Compile Include="GitHub.App\ViewModels\LoginToGitHubViewModelTests.cs" />
+    <Compile Include="GitHub.App\ViewModels\PullRequestCreationViewModelTests.cs" />
     <Compile Include="GitHub.App\ViewModels\PullRequestListViewModelTests.cs" />
     <Compile Include="GitHub.App\ViewModels\RepositoryCloneViewModelTests.cs" />
     <Compile Include="GitHub.App\ViewModels\RepositoryCreationViewModelTests.cs" />