PullRequestSession is shared and shouldn't be disposed

Author: jcansdale

src/GitHub.InlineReviews/Services/PullRequestSession.cs

@@ -21,7 +21,9 @@ namespace GitHub.InlineReviews.Services
     /// It takes the pull request model and updates according to the current state of the
     /// repository on disk and in the editor.
     /// </remarks>
-    public class PullRequestSession : ReactiveObject, IPullRequestSession, IDisposable
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1001:TypesThatOwnDisposableFieldsShouldBeDisposable",
+        Justification = "PullRequestSession is shared and shouldn't be disposed")]
+    public class PullRequestSession : ReactiveObject, IPullRequestSession
     {
         readonly IPullRequestSessionService service;
         readonly Dictionary<string, PullRequestSessionFile> fileIndex = new Dictionary<string, PullRequestSessionFile>();
@@ -160,28 +162,6 @@ public async Task Update(IPullRequestModel pullRequestModel)
             pullRequestChanged.OnNext(pullRequestModel);
         }
 
-        public void Dispose()
-        {
-            Dispose(true);
-            GC.SuppressFinalize(this);
-        }
-
-        bool disposed = false;
-
-        protected virtual void Dispose(bool disposing)
-        {
-            if (!disposed)
-            {
-                disposed = true;
-
-                if (disposing)
-                {
-                    getFilesLock.Dispose();
-                    pullRequestChanged.Dispose();
-                }
-            }
-        }
-
         async Task AddComment(IPullRequestReviewCommentModel comment)
         {
             PullRequest.ReviewComments = PullRequest.ReviewComments