Don't expect tags when margin invisible

Author: jcansdale

test/GitHub.InlineReviews.UnitTests/Tags/InlineCommentTaggerTests.cs

@@ -11,6 +11,7 @@
 using Microsoft.VisualStudio.Text.Editor;
 using NSubstitute;
 using NUnit.Framework;
+using GitHub.InlineReviews.Margins;
 
 namespace GitHub.InlineReviews.UnitTests.Tags
 {
@@ -298,16 +299,17 @@ public void ShouldNotReturnAddNewCommentTagForDeletedLineOnRhs()
                 var span = CreateSpan(13);
                 var firstPass = target.GetTags(span);
                 var result = target.GetTags(span).ToList();
-                 Assert.That(result, Is.Empty);
+                Assert.That(result, Is.Empty);
             }
 
-            [Test]
-            public void ShouldRaiseTagsChangedOnFileLinesChanged()
+            [TestCase(true, true)]
+            [TestCase(false, false)]
+            public void ShouldRaiseTagsChangedOnFileLinesChanged(bool inlineCommentMarginVisible, bool expectRaised)
             {
                 var file = CreateSessionFile();
                 var manager = CreateSessionManager(file);
                 var target = new InlineCommentTagger(
-                    Substitute.For<ITextView>(),
+                    CreateTextView(inlineCommentMarginVisible),
                     CreateBuffer(),
                     manager);
 
@@ -322,7 +324,7 @@ public void ShouldRaiseTagsChangedOnFileLinesChanged()
                     Tuple.Create(14, DiffSide.Right),
                 });
 
-                Assert.True(raised);
+                Assert.That(raised, Is.EqualTo(expectRaised));
             }
 
             [Test]
@@ -349,6 +351,13 @@ public void ShouldNotRaiseTagsChangedOnLeftHandSideLinesChanged()
                 Assert.False(raised);
             }
 
+            static ITextView CreateTextView(bool inlineCommentMarginVisible = true)
+            {
+                var textView = Substitute.For<ITextView>();
+                textView.Options.GetOptionValue<bool>(InlineCommentMarginVisible.OptionName).Returns(inlineCommentMarginVisible);
+                return textView;
+            }
+
             static IPullRequestSessionFile CreateSessionFile()
             {
                 var diffChunk = new DiffChunk