Pass Git path to PullRequestTextBufferInfo

Consistently new up PullRequestTextBufferInfo with Git relative path.

Author: jcansdale

src/GitHub.App/Services/PullRequestEditorService.cs

@@ -119,8 +119,12 @@ public async Task<ITextView> OpenFile(
 
                     if (!workingDirectory)
                     {
-                        AddBufferTag(wpfTextView.TextBuffer, session, fullPath, commitSha, null);
-                        EnableNavigateToEditor(textView, session);
+                        var gitPath = FindGitPath(session.LocalRepository, fullPath);
+                        if (gitPath != null)
+                        {
+                            AddBufferTag(wpfTextView.TextBuffer, session, gitPath, commitSha, null);
+                            EnableNavigateToEditor(textView, session);
+                        }
                     }
                 }
 
@@ -485,6 +489,17 @@ static string GetAbsolutePath(LocalRepositoryModel localRepository, string relat
             return Path.Combine(localPath, relativePath);
         }
 
+        static string FindGitPath(LocalRepositoryModel localRepository, string path)
+        {
+            var basePath = localRepository.LocalPath + Path.DirectorySeparatorChar;
+            if (path.StartsWith(basePath, StringComparison.OrdinalIgnoreCase))
+            {
+                return path.Substring(basePath.Length).Replace(Path.DirectorySeparatorChar, '/');
+            }
+
+            return null;
+        }
+
         string GetText(IVsTextView textView)
         {
             IVsTextLines buffer;
@@ -561,21 +576,23 @@ void ShowErrorInStatusBar(string message, Exception e)
         void AddBufferTag(
             ITextBuffer buffer,
             IPullRequestSession session,
-            string path,
+            string gitPath,
             string commitSha,
             DiffSide? side)
         {
+            Guard.ArgumentIsGitPath(gitPath, nameof(gitPath));
+
             buffer.Properties.GetOrCreateSingletonProperty(
                 typeof(PullRequestTextBufferInfo),
-                () => new PullRequestTextBufferInfo(session, path, commitSha, side));
+                () => new PullRequestTextBufferInfo(session, gitPath, commitSha, side));
 
             var projection = buffer as IProjectionBuffer;
 
             if (projection != null)
             {
                 foreach (var source in projection.SourceBuffers)
                 {
-                    AddBufferTag(source, session, path, commitSha, side);
+                    AddBufferTag(source, session, gitPath, commitSha, side);
                 }
             }
         }

src/GitHub.InlineReviews/Services/PullRequestSession.cs

@@ -110,22 +110,6 @@ public async Task<string> GetMergeBase()
             return mergeBase;
         }
 
-        /// <inheritdoc/>
-        public string GetRelativePath(string path)
-        {
-            if (Path.IsPathRooted(path))
-            {
-                var basePath = LocalRepository.LocalPath;
-
-                if (path.StartsWith(basePath, StringComparison.OrdinalIgnoreCase) && path.Length > basePath.Length + 1)
-                {
-                    return path.Substring(basePath.Length + 1);
-                }
-            }
-
-            return null;
-        }
-
         /// <inheritdoc/>
         public async Task PostReviewComment(
             string body,