Open clone dialog on tab for URL

Add IRepositoryCloneViewModel.Url property.
Select the tab corresponding to the host.
Don't select a tab when host doesn't match.

Author: jcansdale

src/GitHub.App/SampleData/Dialog/Clone/RepositoryCloneViewModelDesigner.cs

@@ -2,6 +2,7 @@
 using System.Reactive;
 using System.Threading.Tasks;
 using GitHub.Models;
+using GitHub.Primitives;
 using GitHub.ViewModels;
 using GitHub.ViewModels.Dialog.Clone;
 using ReactiveUI;
@@ -17,6 +18,7 @@ public RepositoryCloneViewModelDesigner()
         }
 
         public string Path { get; set; }
+        public UriString Url { get; set; }
         public string PathWarning { get; set; }
         public int SelectedTabIndex { get; set; }
         public string Title => null;

src/GitHub.App/Services/DialogService.cs

@@ -51,8 +51,7 @@ public async Task<CloneDialogResult> ShowCloneDialog(IConnection connection, str
             var viewModel = factory.CreateViewModel<IRepositoryCloneViewModel>();
             if (url != null)
             {
-                viewModel.GitHubTab.Filter = url;
-                viewModel.EnterpriseTab.Filter = url;
+                viewModel.Url = url;
             }
 
             if (connection != null)

src/GitHub.App/ViewModels/Dialog/Clone/RepositoryCloneViewModel.cs

@@ -9,6 +9,7 @@
 using GitHub.Extensions;
 using GitHub.Logging;
 using GitHub.Models;
+using GitHub.Primitives;
 using GitHub.Services;
 using ReactiveUI;
 using Rothko;
@@ -29,6 +30,7 @@ public class RepositoryCloneViewModel : ViewModelBase, IRepositoryCloneViewModel
         readonly IUsageTracker usageTracker;
         readonly IReadOnlyList<IRepositoryCloneTabViewModel> tabs;
         string path;
+        UriString url;
         RepositoryModel previousRepository;
         ObservableAsPropertyHelper<string> pathWarning;
         int selectedTabIndex;
@@ -93,6 +95,12 @@ public string Path
             set => this.RaiseAndSetIfChanged(ref path, value);
         }
 
+        public UriString Url
+        {
+            get => url;
+            set => this.RaiseAndSetIfChanged(ref url, value);
+        }
+
         public string PathWarning => pathWarning.Value;
 
         public int SelectedTabIndex
@@ -132,6 +140,20 @@ public async Task InitializeAsync(IConnection connection)
                 SelectedTabIndex = 1;
             }
 
+            if (Url?.Host is string host && HostAddress.Create(host) is HostAddress hostAddress)
+            {
+                if (hostAddress == gitHubConnection?.HostAddress)
+                {
+                    GitHubTab.Filter = Url;
+                    SelectedTabIndex = 0;
+                }
+                else if (hostAddress == enterpriseConnection?.HostAddress)
+                {
+                    EnterpriseTab.Filter = Url;
+                    SelectedTabIndex = 1;
+                }
+            }
+
             this.WhenAnyValue(x => x.SelectedTabIndex).Subscribe(x => tabs[x].Activate().Forget());
 
             switch (SelectedTabIndex)

src/GitHub.Exports.Reactive/ViewModels/Dialog/Clone/IRepositoryCloneViewModel.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Reactive;
 using GitHub.Models;
+using GitHub.Primitives;
 using ReactiveUI;
 
 namespace GitHub.ViewModels.Dialog.Clone
@@ -20,6 +21,11 @@ public interface IRepositoryCloneViewModel : IDialogContentViewModel, IConnectio
         /// </summary>
         IRepositorySelectViewModel EnterpriseTab { get; }
 
+        /// <summary>
+        /// Initial URL for the dialog.
+        /// </summary>
+        UriString Url { get; set; }
+
         /// <summary>
         /// Gets the path to clone the repository to.
         /// </summary>

test/GitHub.App.UnitTests/ViewModels/Dialog/Clone/RepositoryCloneViewModelTests.cs

@@ -23,6 +23,40 @@ public class RepositoryCloneViewModelTests
         const string fileExists = "d:\\exists\\file";
         const string defaultPath = "d:\\default\\path";
 
+        public class TheUrlProperty
+        {
+            [TestCase("https://github.com;https://enterprise.com", null, 0)]
+            [TestCase("https://github.com;https://enterprise.com", "https://github.com/foo/bar", 0)]
+            [TestCase("https://github.com;https://enterprise.com", "https://enterprise.com/foo/bar", 1)]
+            [TestCase("https://github.com;https://enterprise.com", "https://unknown.com/foo/bar", 0)]
+            public async Task Select_Tab_For_Url(string addresses, string url, int expectTabIndex)
+            {
+                var cm = CreateConnectionManager(addresses.Split(';'));
+                var target = CreateTarget(connectionManager: cm);
+                target.Url = url;
+
+                await target.InitializeAsync(null);
+
+                Assert.That(target.SelectedTabIndex, Is.EqualTo(expectTabIndex));
+            }
+
+            [TestCase("https://github.com;https://enterprise.com", null, "", "")]
+            [TestCase("https://github.com;https://enterprise.com", "https://github.com/foo/bar", "https://github.com/foo/bar", "")]
+            [TestCase("https://github.com;https://enterprise.com", "https://enterprise.com/foo/bar", "", "https://enterprise.com/foo/bar")]
+            [TestCase("https://github.com;https://enterprise.com", "https://unknown.com/foo/bar", "", "")]
+            public async Task Set_Filter_For_Url(string addresses, string url, string expectGitHubFilter, string expectEnterpriseFilter)
+            {
+                var cm = CreateConnectionManager(addresses.Split(';'));
+                var target = CreateTarget(connectionManager: cm);
+                target.Url = url;
+
+                await target.InitializeAsync(null);
+
+                Assert.That(target.GitHubTab.Filter, Is.EqualTo(expectGitHubFilter));
+                Assert.That(target.EnterpriseTab.Filter, Is.EqualTo(expectEnterpriseFilter));
+            }
+        }
+
         [Test]
         public async Task GitHubPage_Is_Initialized()
         {