Rename InitializeTask to PendingTasks

PendingTasks is used to execute tasks in order on the thread pool.

Author: jcansdale

src/GitHub.TeamFoundation.14/Services/VSGitExt.cs

@@ -43,11 +43,9 @@ public VSGitExt(IGitHubServiceProvider serviceProvider, IVSUIContextFactory fact
             // It will become available when moving to a Git based solution (and cause a UIContext event to fire).
             context = factory.GetUIContext(new Guid(Guids.GitSccProviderId));
 
-            // Start with empty array until we have a change to initialize.
+            // Start with empty array until we have a chance to initialize.
             ActiveRepositories = Array.Empty<ILocalRepositoryModel>();
 
-            InitializeTask = Task.CompletedTask;
-
             if (context.IsActive && TryInitialize())
             {
                 // Refresh ActiveRepositories on background thread so we don't delay startup.
@@ -97,8 +95,8 @@ bool TryInitialize()
 
         void QueueRefreshActiveRepositories()
         {
-            // Execute tasks in sequence on thread pool.
-            InitializeTask = InitializeTask.ContinueWith(_ => RefreshActiveRepositories(), TaskScheduler.Default);
+            // Execute tasks in sequence using thread pool (TaskScheduler.Default).
+            PendingTasks = PendingTasks.ContinueWith(_ => RefreshActiveRepositories(), TaskScheduler.Default);
         }
 
         void RefreshActiveRepositories()
@@ -139,6 +137,9 @@ private set
 
         public event Action ActiveRepositoriesChanged;
 
-        public Task InitializeTask { get; private set; }
+        /// <summary>
+        /// Tasks that are pending execution on the thread pool.
+        /// </summary>
+        public Task PendingTasks { get; private set; } = Task.CompletedTask;
     }
 }

test/UnitTests/GitHub.TeamFoundation/VSGitExtTests.cs

@@ -75,7 +75,7 @@ public async Task GitExtPropertyChangedEvent_ActiveRepositoriesChangedIsFired()
             var eventArgs = new PropertyChangedEventArgs(nameof(gitExt.ActiveRepositories));
             gitExt.PropertyChanged += Raise.Event<PropertyChangedEventHandler>(gitExt, eventArgs);
 
-            await target.InitializeTask;
+            await target.PendingTasks;
             Assert.That(wasFired, Is.True);
         }
 
@@ -109,7 +109,7 @@ public void WhenUIContextChanged_ActiveRepositoriesChangedIsFired()
 
             var eventArgs = new VSUIContextChangedEventArgs(true);
             context.UIContextChanged += Raise.Event<EventHandler<VSUIContextChangedEventArgs>>(context, eventArgs);
-            target.InitializeTask.Wait();
+            target.PendingTasks.Wait();
 
             Assert.That(wasFired, Is.True);
         }
@@ -126,7 +126,7 @@ public void WhenUIContextChanged_FiredUsingThreadPoolThread()
 
             var eventArgs = new VSUIContextChangedEventArgs(true);
             context.UIContextChanged += Raise.Event<EventHandler<VSUIContextChangedEventArgs>>(context, eventArgs);
-            target.InitializeTask.Wait();
+            target.PendingTasks.Wait();
 
             Assert.That(threadPool, Is.True);
         }
@@ -151,7 +151,7 @@ public void SccProviderContextIsActive_InitializeWithActiveRepositories()
             var context = CreateVSUIContext(true);
             var gitExt = CreateGitExt(new[] { repoPath });
             var target = CreateVSGitExt(context, gitExt, repoFactory: repoFactory);
-            target.InitializeTask.Wait();
+            target.PendingTasks.Wait();
 
             var activeRepositories = target.ActiveRepositories;
 
@@ -168,7 +168,7 @@ public void ExceptionRefreshingRepositories_ReturnsEmptyList()
             var context = CreateVSUIContext(true);
             var gitExt = CreateGitExt(new[] { repoPath });
             var target = CreateVSGitExt(context, gitExt, repoFactory: repoFactory);
-            target.InitializeTask.Wait();
+            target.PendingTasks.Wait();
 
             var activeRepositories = target.ActiveRepositories;
 
@@ -189,7 +189,7 @@ public async Task ActiveRepositoriesChangedOrderingShouldBeCorrectAcrossThreads(
             var task2 = Task.Run(() => gitExt.ActiveRepositories = activeRepositories2);
 
             await Task.WhenAll(task1, task2);
-            await target.InitializeTask;
+            await target.PendingTasks;
 
             Assert.That(target.ActiveRepositories.Single().LocalPath, Is.EqualTo("repo2"));
         }
@@ -221,7 +221,7 @@ static VSGitExt CreateVSGitExt(IVSUIContext context = null, IGitExt gitExt = nul
         sp.GetService<IVSUIContextFactory>().Returns(factory);
         sp.GetService<IGitExt>().Returns(gitExt);
         var vsGitExt = new VSGitExt(sp, factory, repoFactory);
-        vsGitExt.InitializeTask.Wait();
+        vsGitExt.PendingTasks.Wait();
         return vsGitExt;
     }