Rename to Paths.ToWindowsPath from ToRelativePath

ToWindowsPath is clearer because it doesn't convert from an absolute path.

Author: jcansdale

src/GitHub.App/Services/GitHubContextService.cs

@@ -282,7 +282,7 @@ public bool TryOpenFile(string repositoryDir, GitHubContext context)
                 return false;
             }
 
-            var relativePath = Paths.ToRelativePath(path);
+            var relativePath = Paths.ToWindowsPath(path);
             var fullPath = Path.Combine(repositoryDir, relativePath);
             var textView = OpenDocument(fullPath);
             SetSelection(textView, context);

src/GitHub.App/Services/PullRequestEditorService.cs

@@ -638,7 +638,7 @@ async Task<string> GetBaseFileName(IPullRequestSession session, IPullRequestSess
                 var gitPath = Paths.ToGitPath(file.RelativePath);
                 var fileChange = changes.FirstOrDefault(x => x.Path == gitPath);
                 return fileChange?.Status == LibGit2Sharp.ChangeKind.Renamed ?
-                    Paths.ToRelativePath(fileChange.OldPath) : file.RelativePath;
+                    Paths.ToWindowsPath(fileChange.OldPath) : file.RelativePath;
             }
         }
 

src/GitHub.App/ViewModels/GitHubPane/PullRequestDirectoryNode.cs

@@ -17,7 +17,7 @@ public class PullRequestDirectoryNode : IPullRequestDirectoryNode
         public PullRequestDirectoryNode(string relativeOrGitPath)
         {
             DirectoryName = System.IO.Path.GetFileName(relativeOrGitPath);
-            RelativePath = Paths.ToRelativePath(relativeOrGitPath);
+            RelativePath = Paths.ToWindowsPath(relativeOrGitPath);
             Directories = new List<IPullRequestDirectoryNode>();
             Files = new List<IPullRequestFileNode>();
         }

src/GitHub.App/ViewModels/GitHubPane/PullRequestFileNode.cs

@@ -42,7 +42,7 @@ public PullRequestFileNode(
             Guard.ArgumentNotEmptyString(sha, nameof(sha));
 
             FileName = Path.GetFileName(relativeOrGitPath);
-            RelativePath = Paths.ToRelativePath(relativeOrGitPath);
+            RelativePath = Paths.ToWindowsPath(relativeOrGitPath);
             Sha = sha;
             Status = status;
             OldPath = oldPath;

src/GitHub.Exports/Primitives/Paths.cs

@@ -21,11 +21,11 @@ public static string ToGitPath(string relativePath)
         }
 
         /// <summary>
-        /// Convert from a Git path to a relative path.
+        /// Convert from a Git path to a path that uses the Windows directory separator ('\').
         /// </summary>
-        /// <param name="gitPath">A working directory relative path which uses the '/' directory separator.</param>
-        /// <returns>A relative paht that uses the <see cref="Path.DirectorySeparatorChar"/> directory separator.</returns>
-        public static string ToRelativePath(string gitPath)
+        /// <param name="gitPath">A relative path that uses the '/' directory separator.</param>
+        /// <returns>A relative path that uses the <see cref="Path.DirectorySeparatorChar"/> directory separator ('\' on Windows).</returns>
+        public static string ToWindowsPath(string gitPath)
         {
             return gitPath.Replace(GitDirectorySeparatorChar, Path.DirectorySeparatorChar);
         }