Show custom notifications for cloned repos too

Now both creating and cloning show messages with the url of the
repository, plus a link to create or open a project/solution, depending
on the situation.
If it's a created repo, link to the Create dialog.
If it's a cloned repo that doesn't have commits, link to the Create
dialog.
If it's a cloned repo that has commits, link to the Open dialog.

Author: shana

src/GitHub.VisualStudio/Helpers/Constants.cs

@@ -1,10 +1,15 @@
 namespace GitHub.VisualStudio.Helpers
 {
-    public static class Constants
+    internal static class Constants
     {
         public const string NoAngleBracketsErrorMessage = "Failed to parse signature - Neither `name` nor `email` should contain angle brackets chars.";
         public const int MaxRepositoryNameLength = 100;
         public const int MaxDirectoryLength = 200; // Windows allows 248, but we need to allow room for subdirectories.
         public const int MaxFilePathLength = 260;
+
+        public const string Notification_RepoCreated = "[{0}](u:{1}) has been successfully created.";
+        public const string Notification_RepoCloned = "[{0}](u:{1}) has been successfully cloned.";
+        public const string Notification_CreateNewProject = "[Create a new project or solution](c:{0})";
+        public const string Notification_OpenProject = "[Open an existing project or solution](o:{0})";
     }
 }

src/GitHub.VisualStudio/TeamExplorer/Connect/GitHubConnectSection.cs

@@ -197,18 +197,15 @@ async void UpdateRepositoryList(object sender, NotifyCollectionChangedEventArgs
                 if (isCloning || isCreating)
                 {
                     var newrepo = e.NewItems.Cast<ISimpleRepositoryModel>().First();
+
                     SelectedRepository = newrepo;
                     if (isCreating)
                         HandleCreatedRepo(newrepo);
+                    else
+                        HandleClonedRepo(newrepo);
 
-                    // if we've cloned a repo but the user didn't open a project in it,
-                    // then update the newly-cloned repo icon because we're not going to
-                    // switch to the TE home page
-                    if ((isCloning && !OpenRepository()) || isCreating)
-                    {
-                        var repo = await ApiFactory.Create(newrepo.CloneUrl).GetRepository();
-                        newrepo.SetIcon(repo.Private, repo.Fork);
-                    }
+                    var repo = await ApiFactory.Create(newrepo.CloneUrl).GetRepository();
+                    newrepo.SetIcon(repo.Private, repo.Fork);
                 }
                 // looks like it's just a refresh with new stuff on the list, update the icons
                 else
@@ -227,24 +224,55 @@ async void UpdateRepositoryList(object sender, NotifyCollectionChangedEventArgs
         }
 
         void HandleCreatedRepo(ISimpleRepositoryModel newrepo)
+        {
+            var msg = string.Format(CultureInfo.CurrentUICulture, Constants.Notification_RepoCreated, newrepo.Name, newrepo.CloneUrl);
+            msg += " " + string.Format(CultureInfo.CurrentUICulture, Constants.Notification_CreateNewProject, newrepo.LocalPath);
+            ShowNotification(newrepo, msg);
+        }
+
+        void HandleClonedRepo(ISimpleRepositoryModel newrepo)
+        {
+            var msg = string.Format(CultureInfo.CurrentUICulture, Constants.Notification_RepoCloned, newrepo.Name, newrepo.CloneUrl);
+            if (newrepo.HasCommits())
+                msg += " " + string.Format(CultureInfo.CurrentUICulture, Constants.Notification_OpenProject, newrepo.LocalPath);
+            else
+                msg += " " + string.Format(CultureInfo.CurrentUICulture, Constants.Notification_CreateNewProject, newrepo.LocalPath);
+            ShowNotification(newrepo, msg);
+        }
+
+        void ShowNotification(ISimpleRepositoryModel newrepo, string msg)
         {
             var vsservices = ServiceProvider.GetExportedValue<IVSServices>();
             vsservices.ClearNotifications();
             vsservices.ShowMessage(
-                string.Format(CultureInfo.CurrentUICulture, "[{0}](u:{1}) has been successfully created. [Create a new project or solution](p:{2})", newrepo.Name, newrepo.CloneUrl, newrepo.LocalPath),
+                msg,
                 new RelayCommand((o) =>
                 {
                     var str = o.ToString();
+                    /* the prefix is the action to perform:
+                     * u: launch browser with url
+                     * c: launch create new project dialog
+                     * o: launch open existing project dialog 
+                    */
                     var prefix = str.Substring(0, 2);
                     if (prefix == "u:")
                         OpenInBrowser(ServiceProvider.TryGetService<IVisualStudioBrowser>(), new Uri(str.Substring(2)));
-                    else if (prefix == "p:")
+                    else if (prefix == "o:")
                     {
                         if (ErrorHandler.Succeeded(ServiceProvider.GetSolution().OpenSolutionViaDlg(str.Substring(2), 1)))
                             ServiceProvider.TryGetService<ITeamExplorer>()?.NavigateToPage(new Guid(TeamExplorerPageIds.Home), null);
                     }
+                    else if (prefix == "c:")
+                    {
+                        vsservices.SetDefaultProjectPath(newrepo.LocalPath);
+                        if (ErrorHandler.Succeeded(ServiceProvider.GetSolution().CreateNewProjectViaDlg(null, null, 0)))
+                            ServiceProvider.TryGetService<ITeamExplorer>()?.NavigateToPage(new Guid(TeamExplorerPageIds.Home), null);
+                    }
                 })
             );
+#if DEBUG
+            VsOutputLogger.WriteLine(String.Format(CultureInfo.InvariantCulture, "{0} Notification", DateTime.Now));
+#endif
         }
 
         void RefreshRepositories()
@@ -356,11 +384,18 @@ public SectionStateTracker(ITeamExplorerSection section, Action onRefreshed)
 
                 section.PropertyChanged += TrackState;
             }
-
+#if DEBUG
+            [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily")]
+#endif
             void TrackState(object sender, PropertyChangedEventArgs e)
             {
                 if (machine.PermittedTriggers.Contains(e.PropertyName))
+                {
+#if DEBUG
+                    VsOutputLogger.WriteLine(String.Format(CultureInfo.InvariantCulture, "{3} {0} title:{1} busy:{2}", e.PropertyName, ((ITeamExplorerSection)sender).Title, ((ITeamExplorerSection)sender).IsBusy, DateTime.Now));
+#endif
                     machine.Fire(e.PropertyName);
+                }
             }
         }
     }