Use consts for URLs and Guids.

Author: grokys

src/GitHub.App/Info/GitHubUrls.cs

@@ -94,5 +94,10 @@ public static string Billing(this IAccount account)
                 : string.Format(CultureInfo.InvariantCulture,
                     GitHub + "/organizations/{0}/settings/billing", account.Login);
         }
+
+        /// <summary>
+        /// The URL for the GitHub for Visual Studio documentation.
+        /// </summary>
+        public const string Documentation = "https://visualstudio.github.com/docs";
     }
 }

src/GitHub.Exports/Settings/Guids.cs

@@ -12,8 +12,10 @@ public static class Guids
         public const string GitHubServiceProviderId = "76909E1A-9D58-41AB-8957-C26B9550787B";
         public const string StartPagePackageId = "3b764d23-faf7-486f-94c7-b3accc44a70e";
         public const string CodeContainerProviderId = "6CE146CB-EF57-4F2C-A93F-5BA685317660";
+        public const string TeamExplorerWelcomeMessage = "C529627F-8AA6-4FDB-82EB-4BFB7DB753C3";
 
         // VisualStudio IDs
         public const string GitSccProviderId = "11B8E6D7-C08B-4385-B321-321078CDD1F8";
+        public const string TeamExplorerInstall3rdPartyGitTools = "DF785C7C-8454-4836-9686-D1C4A01D0BB9";
     }
 }

src/GitHub.TeamFoundation.14/Home/GitHubHomeSection.cs

@@ -16,6 +16,7 @@
 using GitHub.VisualStudio.UI;
 using GitHub.Settings;
 using System.Windows.Threading;
+using GitHub.Info;
 
 namespace GitHub.VisualStudio.TeamExplorer.Home
 {
@@ -25,7 +26,6 @@ public class GitHubHomeSection : TeamExplorerSectionBase, IGitHubHomeSection
     {
         public const string GitHubHomeSectionId = "72008232-2104-4FA0-A189-61B0C6F91198";
         const string TrainingUrl = "https://services.github.com/on-demand/windows/visual-studio";
-        const string DocsUrl = "https://visualstudio.github.com/docs";
 
         readonly IVisualStudioBrowser visualStudioBrowser;
         readonly ITeamExplorerServices teamExplorerServices;
@@ -76,7 +76,7 @@ public GitHubHomeSection(IGitHubServiceProvider serviceProvider,
 
         bool IsGitToolsMessageVisible()
         {
-            return teamExplorerServices.IsNotificationVisible(new Guid("DF785C7C-8454-4836-9686-D1C4A01D0BB9"));
+            return teamExplorerServices.IsNotificationVisible(new Guid(Guids.TeamExplorerInstall3rdPartyGitTools));
         }
 
         protected async override void RepoChanged(bool changed)
@@ -149,7 +149,7 @@ void DoOpenOnGitHub()
 
         void ShowWelcomeMessage()
         {
-            var welcomeMessageGuid = new Guid("C529627F-8AA6-4FDB-82EB-4BFB7DB753C3");
+            var welcomeMessageGuid = new Guid(Guids.TeamExplorerWelcomeMessage);
             teamExplorerServices.ShowMessage(
                 Resources.TeamExplorerWelcomeMessage,
                 new RelayCommand(o =>
@@ -163,7 +163,7 @@ void ShowWelcomeMessage()
                             usageTracker.IncrementWelcomeTrainingClicks().Forget();
                             break;
                         case "show-docs":
-                            visualStudioBrowser.OpenUrl(new Uri(DocsUrl));
+                            visualStudioBrowser.OpenUrl(new Uri(GitHubUrls.Documentation));
                             usageTracker.IncrementWelcomeDocsClicks().Forget();
                             break;
                         case "dont-show-again":

src/GitHub.VisualStudio/UI/Views/GitHubPaneViewModel.cs

@@ -16,7 +16,7 @@
 using System.Reactive.Linq;
 using System.Threading.Tasks;
 using System.Windows.Input;
-
+using GitHub.Info;
 
 namespace GitHub.VisualStudio.UI.Views
 {
@@ -132,7 +132,7 @@ public override void Initialize(IServiceProvider serviceProvider)
                 () => true,
                 () =>
                 {
-                    browser.OpenUrl(new Uri("https://visualstudio.github.com/docs"));
+                    browser.OpenUrl(new Uri(GitHubUrls.Documentation));
                     usageTracker.IncrementGitHubPaneHelpClicks().Forget();
                 },
                 true);