Fix various CA warnings in tests.

Author: grokys

test/GitHub.App.UnitTests/ViewModels/PullRequestReviewCommentThreadViewModelTests.cs

@@ -1,4 +1,5 @@
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
 using System.Reactive.Concurrency;
 using System.Reactive.Linq;
@@ -66,7 +67,7 @@ public async Task PostsCommentInReplyToCorrectComment()
             target.Comments[2].Body = "New Comment";
             await target.Comments[2].CommitEdit.Execute();
 
-            session.Received(1).PostReviewComment("New Comment", "1");
+            await session.Received(1).PostReviewComment("New Comment", "1");
         }
 
         [Test]
@@ -158,18 +159,18 @@ IEnumerable<InlineCommentModel> CreateComments(params string[] bodies)
 
             foreach (var body in bodies)
             {
-                yield return CreateComment((id++).ToString(), body);
+                yield return CreateComment((id++).ToString(CultureInfo.InvariantCulture), body);
             }
         }
 
-        IPullRequestSessionFile CreateFile(string relativePath = "file.cs")
+        static IPullRequestSessionFile CreateFile(string relativePath = "file.cs")
         {
             var result = Substitute.For<IPullRequestSessionFile>();
             result.RelativePath.Returns(relativePath);
             return result;
         }
 
-        IViewViewModelFactory CreateFactory()
+        static IViewViewModelFactory CreateFactory()
         {
             var result = Substitute.For<IViewViewModelFactory>();
             var commentService = Substitute.For<ICommentService>();
@@ -178,7 +179,7 @@ IViewViewModelFactory CreateFactory()
             return result;
         }
 
-        IPullRequestSession CreateSession()
+        static IPullRequestSession CreateSession()
         {
             var result = Substitute.For<IPullRequestSession>();
             result.User.Returns(new ActorModel { Login = "Viewer" });

test/GitHub.InlineReviews.UnitTests/ViewModels/InlineCommentPeekViewModelTests.cs

@@ -255,20 +255,7 @@ void AddCommentToExistingThread(IPullRequestSessionFile file)
             RaiseLinesChanged(file, Tuple.Create(thread.LineNumber, DiffSide.Right));
         }
 
-        IApiClientFactory CreateApiClientFactory()
-        {
-            var apiClient = Substitute.For<IApiClient>();
-            apiClient.CreatePullRequestReviewComment(null, null, 0, null, 0)
-                .ReturnsForAnyArgs(_ => Observable.Return(new PullRequestReviewComment()));
-            apiClient.CreatePullRequestReviewComment(null, null, 0, null, null, null, 0)
-                .ReturnsForAnyArgs(_ => Observable.Return(new PullRequestReviewComment()));
-
-            var result = Substitute.For<IApiClientFactory>();
-            result.Create(null).ReturnsForAnyArgs(apiClient);
-            return result;
-        }
-
-        InlineCommentModel CreateComment(string body)
+        static InlineCommentModel CreateComment(string body)
         {
             return new InlineCommentModel
             {
@@ -280,7 +267,7 @@ InlineCommentModel CreateComment(string body)
             };
         }
 
-        IViewViewModelFactory CreateFactory()
+        static IViewViewModelFactory CreateFactory()
         {
             var draftStore = Substitute.For<IMessageDraftStore>();
             var commentService = Substitute.For<ICommentService>();
@@ -292,7 +279,7 @@ IViewViewModelFactory CreateFactory()
             return result;
         }
 
-        IInlineCommentThreadModel CreateThread(int lineNumber, params string[] comments)
+        static IInlineCommentThreadModel CreateThread(int lineNumber, params string[] comments)
         {
             var result = Substitute.For<IInlineCommentThreadModel>();
             var commentList = comments.Select(x => CreateComment(x)).ToList();
@@ -301,14 +288,14 @@ IInlineCommentThreadModel CreateThread(int lineNumber, params string[] comments)
             return result;
         }
 
-        IInlineCommentPeekService CreatePeekService(int lineNumber)
+        static IInlineCommentPeekService CreatePeekService(int lineNumber)
         {
             var result = Substitute.For<IInlineCommentPeekService>();
             result.GetLineNumber(null, null).ReturnsForAnyArgs(Tuple.Create(lineNumber, false));
             return result;
         }
 
-        IPeekSession CreatePeekSession()
+        static IPeekSession CreatePeekSession()
         {
             var document = Substitute.For<ITextDocument>();
             document.FilePath.Returns(FullPath);
@@ -322,7 +309,7 @@ IPeekSession CreatePeekSession()
             return result;
         }
 
-        IPullRequestSession CreateSession()
+        static IPullRequestSession CreateSession()
         {
             var result = Substitute.For<IPullRequestSession>();
             result.PullRequest.Returns(new PullRequestDetailModel());
@@ -331,7 +318,7 @@ IPullRequestSession CreateSession()
             return result;
         }
 
-        IPullRequestSessionManager CreateSessionManager(
+        static IPullRequestSessionManager CreateSessionManager(
             string commitSha = "COMMIT",
             string relativePath = RelativePath,
             IPullRequestSession session = null,
@@ -378,13 +365,13 @@ IPullRequestSessionManager CreateSessionManager(
             return result;
         }
 
-        void RaiseLinesChanged(IPullRequestSessionFile file, params Tuple<int, DiffSide>[] lineNumbers)
+        static void RaiseLinesChanged(IPullRequestSessionFile file, params Tuple<int, DiffSide>[] lineNumbers)
         {
             var subject = (Subject<IReadOnlyList<Tuple<int, DiffSide>>>)file.LinesChanged;
             subject.OnNext(lineNumbers);
         }
 
-        void RaisePropertyChanged<T>(T o, string propertyName)
+        static void RaisePropertyChanged<T>(T o, string propertyName)
             where T : INotifyPropertyChanged
         {
             o.PropertyChanged += Raise.Event<PropertyChangedEventHandler>(new PropertyChangedEventArgs(propertyName));