clean up and set initial visibility to collapsed

Author: paladique

src/GitHub.VisualStudio/UI/Views/GitHubPaneView.xaml

@@ -41,10 +41,10 @@
   </UserControl.Resources>
 
   <DockPanel>
-    <StackPanel Margin="6,9,9,5"
+        <control:ErrorStrip x:Name="ErrorMessage" Message="{Binding ErrorMessage}" VerticalAlignment="Top" DockPanel.Dock="Top"></control:ErrorStrip>
+        <StackPanel Margin="6,9,9,5"
                 DockPanel.Dock="Top"
                 Orientation="Horizontal">
-      <control:ErrorStrip x:Name="ErrorMessage" Message="{Binding ErrorMessage}" VerticalAlignment="Top"></control:ErrorStrip>
       <TextBlock Margin="0,-5,0,0"
                  FontSize="14.7"
                  FontWeight="SemiBold"

src/GitHub.VisualStudio/UI/Views/GitHubPaneView.xaml.cs

@@ -2,6 +2,7 @@
 using GitHub.Exports;
 using GitHub.UI;
 using GitHub.ViewModels;
+using System.Windows;
 using ReactiveUI;
 using GitHub.Services;
 using System.Windows.Threading;
@@ -25,13 +26,12 @@ public GitHubPaneView(INotificationDispatcher notifications)
             this.InitializeComponent();
             this.WhenActivated(d =>
             {
+                ErrorMessage.Visibility = Visibility.Collapsed;
                 d(notifications.Listen()
                     .Where(n => n.Type == Notification.NotificationType.Error)
                     .ObserveOnDispatcher(DispatcherPriority.Normal)
                     .Subscribe(n =>
                     {
-                        //errorMessage.Visibility = Visibility.Visible;
-                        // errorMessage = n.Message;
                         ErrorMessage.Message = n.Message;
                     }));
             });

src/GitHub.VisualStudio/UI/Views/GitHubPaneViewModel.cs

@@ -92,9 +92,6 @@ public override void Initialize(IServiceProvider serviceProvider)
             base.Initialize(serviceProvider);
 
             hosts.WhenAnyValue(x => x.IsLoggedInToAnyHost).Subscribe(_ => Reload().Forget());
-
-
-            ErrorMessage = "testing";
         }
 
         public void Initialize([AllowNull] ViewWithData data)

src/GitHub.VisualStudio/UI/Views/PullRequestCreationView.xaml.cs

@@ -22,9 +22,6 @@ public PullRequestCreationView()
             {
                 d(ViewModel.CancelCommand.Subscribe(_ => NotifyCancel()));
                 d(ViewModel.CreatePullRequest.Subscribe(_ => NotifyDone()));
-            
-                //ErrorMessage.Message = "testing the error message";
-
             });
         }
     }