Show a more useful create message

Instead of just showing the remote url of the new repo, show a link to
create a new project or solution locally as well, so the user doesn't
get stuck.

Author: shana

src/GitHub.Exports/Services/VSServices.cs

@@ -12,6 +12,7 @@
 using Microsoft.VisualStudio.Shell.Interop;
 using System.Collections.Generic;
 using GitHub.Models;
+using System.Windows.Input;
 
 namespace GitHub.Services
 {
@@ -25,6 +26,7 @@ public interface IVSServices
         string SetDefaultProjectPath(string path);
 
         void ShowMessage(string message);
+        void ShowMessage(string message, ICommand command);
         void ShowWarning(string message);
         void ShowError(string message);
         void ClearNotifications();
@@ -139,14 +141,39 @@ static string PokeTheRegistryForLocalClonePath()
             }
         }
 
-        const string PathsKey = @"Software\Microsoft\VisualStudio\14.0\NewProjectDialog\MRUSettingsLocalProjectLocationEntries";
+        const string NewProjectDialogKeyPath = @"Software\Microsoft\VisualStudio\14.0\NewProjectDialog";
+        const string MRUKeyPath = "MRUSettingsLocalProjectLocationEntries";
         public string SetDefaultProjectPath(string path)
         {
             string old;
-            using (var key = Registry.CurrentUser.OpenSubKey(PathsKey, true))
+            using (var newProjectKey = Registry.CurrentUser.OpenSubKey(NewProjectDialogKeyPath, true))
             {
-                old = (string)key?.GetValue("Value0", string.Empty, RegistryValueOptions.DoNotExpandEnvironmentNames);
-                key?.SetValue("Value0", path, RegistryValueKind.String);
+                using (var mruKey = newProjectKey?.OpenSubKey(MRUKeyPath, true))
+                {
+                    if (mruKey == null)
+                        return String.Empty;
+
+                    // is this already the default path? bail
+                    old = (string)mruKey.GetValue("Value0", string.Empty, RegistryValueOptions.DoNotExpandEnvironmentNames);
+                    if (String.Equals(path.TrimEnd('\\'), old.TrimEnd('\\'), StringComparison.CurrentCultureIgnoreCase))
+                        return old;
+
+                    // grab the existing list of recent paths, throwing away the last one
+                    var numEntries = (int)mruKey.GetValue("MaximumEntries", 5);
+                    var entries = new List<string>(numEntries);
+                    for (int i = 0; i < numEntries - 1; i++)
+                    {
+                        var val = (string)mruKey.GetValue("Value" + i, String.Empty, RegistryValueOptions.DoNotExpandEnvironmentNames);
+                        if (!String.IsNullOrEmpty(val))
+                            entries.Add(val);
+                    }
+
+                    newProjectKey.SetValue("LastUsedNewProjectPath", path);
+                    mruKey.SetValue("Value0", path);
+                    // bump list of recent paths one entry down
+                    for (int i = 0; i < entries.Count; i++)
+                        mruKey.SetValue("Value" + (i+1), entries[i]);
+                }
             }
             return old;
         }
@@ -158,6 +185,13 @@ public void ShowMessage(string message)
                 manager.ShowNotification(message, NotificationType.Information, NotificationFlags.None, null, default(Guid));
         }
 
+        public void ShowMessage(string message, ICommand command)
+        {
+            var manager = serviceProvider.TryGetService<ITeamExplorer>() as ITeamExplorerNotificationManager;
+            if (manager != null)
+                manager.ShowNotification(message, NotificationType.Information, NotificationFlags.None, command, default(Guid));
+        }
+
         public void ShowWarning(string message)
         {
             var manager = serviceProvider.TryGetService<ITeamExplorer>() as ITeamExplorerNotificationManager;

src/GitHub.VisualStudio/Base/TeamExplorerBase.cs

@@ -44,11 +44,15 @@ public Ret GetService<T, Ret>() where Ret : class
             return GetService<T>() as Ret;
         }
 
-        protected virtual void OpenInBrowser(Lazy<IVisualStudioBrowser> browser, Uri uri)
+        protected void OpenInBrowser(Lazy<IVisualStudioBrowser> browser, Uri uri)
         {
-            var b = browser.Value;
-            Debug.Assert(b != null, "Could not create a browser helper instance.");
-            b?.OpenUrl(uri);
+            OpenInBrowser(browser.Value, uri);
+        }
+
+        protected void OpenInBrowser(IVisualStudioBrowser browser, Uri uri)
+        {
+            Debug.Assert(browser != null, "Could not create a browser helper instance.");
+            browser?.OpenUrl(uri);
         }
     }
 }

src/GitHub.VisualStudio/TeamExplorer/Connect/GitHubConnectSection.cs

@@ -18,6 +18,8 @@
 using ReactiveUI;
 using GitHub.Exports;
 using System.Globalization;
+using Microsoft.TeamFoundation.MVVM;
+using GitHub.Primitives;
 
 namespace GitHub.VisualStudio.TeamExplorer.Connect
 {
@@ -197,11 +199,8 @@ async void UpdateRepositoryList(object sender, NotifyCollectionChangedEventArgs
                     var newrepo = e.NewItems.Cast<ISimpleRepositoryModel>().First();
                     SelectedRepository = newrepo;
                     if (isCreating)
-                    {
-                        var vsservices = ServiceProvider.GetExportedValue<IVSServices>();
-                        vsservices.ClearNotifications();
-                        vsservices.ShowMessage(string.Format(CultureInfo.CurrentUICulture, "[{0}]({1}) has been successfully created.", newrepo.Name, newrepo.CloneUrl));
-                    }
+                        HandleCreatedRepo(newrepo);
+
                     // if we've cloned a repo but the user didn't open a project in it,
                     // then update the newly-cloned repo icon because we're not going to
                     // switch to the TE home page
@@ -227,6 +226,27 @@ async void UpdateRepositoryList(object sender, NotifyCollectionChangedEventArgs
             }
         }
 
+        void HandleCreatedRepo(ISimpleRepositoryModel newrepo)
+        {
+            var vsservices = ServiceProvider.GetExportedValue<IVSServices>();
+            vsservices.ClearNotifications();
+            vsservices.ShowMessage(
+                string.Format(CultureInfo.CurrentUICulture, "[{0}](u:{1}) has been successfully created. [Create a new project or solution](p:{2})", newrepo.Name, newrepo.CloneUrl, newrepo.LocalPath),
+                new RelayCommand((o) =>
+                {
+                    var str = o.ToString();
+                    var prefix = str.Substring(0, 2);
+                    if (prefix == "u:")
+                        OpenInBrowser(ServiceProvider.TryGetService<IVisualStudioBrowser>(), new Uri(str.Substring(2)));
+                    else if (prefix == "p:")
+                    {
+                        if (ErrorHandler.Succeeded(ServiceProvider.GetSolution().OpenSolutionViaDlg(str.Substring(2), 1)))
+                            ServiceProvider.TryGetService<ITeamExplorer>()?.NavigateToPage(new Guid(TeamExplorerPageIds.Home), null);
+                    }
+                })
+            );
+        }
+
         void RefreshRepositories()
         {
             connectionManager.RefreshRepositories();