Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 597d651

Browse files
Changing to an array
1 parent b09aaba commit 597d651

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

src/GitHub.App/SampleData/PullRequestAnnotationsViewModelDesigner.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ public sealed class PullRequestAnnotationsViewModelDesigner : PanePageViewModelB
2020
public ReactiveCommand<Unit, Unit> NavigateToPullRequest { get; }
2121
public string PullRequestTitle { get; } = "Fixing stuff in this PR";
2222
public string CheckSuiteName { get; } = "Awesome Check Suite";
23-
public IReadOnlyDictionary<string, IReadOnlyList<IPullRequestAnnotationItemViewModel>> AnnotationsDictionary { get; }
24-
= new Dictionary<string, IReadOnlyList<IPullRequestAnnotationItemViewModel>>
23+
public IReadOnlyDictionary<string, IPullRequestAnnotationItemViewModel[]> AnnotationsDictionary { get; }
24+
= new Dictionary<string, IPullRequestAnnotationItemViewModel[]>
2525
{
2626
{
2727
"asdf/asdf.cs",

src/GitHub.App/ViewModels/GitHubPane/PullRequestAnnotationsViewModel.cs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class PullRequestAnnotationsViewModel : PanePageViewModelBase, IPullReque
2323
string title;
2424
string checkSuiteName;
2525
string checkRunName;
26-
IReadOnlyDictionary<string, IReadOnlyList<IPullRequestAnnotationItemViewModel>> annotationsDictionary;
26+
IReadOnlyDictionary<string, IPullRequestAnnotationItemViewModel[]> annotationsDictionary;
2727

2828
/// <summary>
2929
/// Initializes a new instance of the <see cref="PullRequestAnnotationsViewModel"/> class.
@@ -101,7 +101,7 @@ public string CheckRunName
101101
private set { this.RaiseAndSetIfChanged(ref checkRunName, value); }
102102
}
103103

104-
public IReadOnlyDictionary<string, IReadOnlyList<IPullRequestAnnotationItemViewModel>> AnnotationsDictionary
104+
public IReadOnlyDictionary<string, IPullRequestAnnotationItemViewModel[]> AnnotationsDictionary
105105
{
106106
get { return annotationsDictionary; }
107107
private set { this.RaiseAndSetIfChanged(ref annotationsDictionary, value); }
@@ -127,8 +127,11 @@ void Load(PullRequestDetailModel pullRequest)
127127
.GroupBy(annotation => annotation.Path)
128128
.ToDictionary(
129129
grouping => grouping.Key,
130-
grouping => (IReadOnlyList<IPullRequestAnnotationItemViewModel>) grouping
131-
.Select(annotation => new PullRequestAnnotationItemViewModel(annotation)));
130+
grouping => grouping
131+
.Select(annotation => new PullRequestAnnotationItemViewModel(annotation))
132+
.Cast<IPullRequestAnnotationItemViewModel>()
133+
.ToArray()
134+
);
132135
}
133136
finally
134137
{

src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestAnnotationsViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public interface IPullRequestAnnotationsViewModel : IPanePageViewModel
5959
/// <summary>
6060
/// Gets a dictionary of annotations by file path.
6161
/// </summary>
62-
IReadOnlyDictionary<string, IReadOnlyList<IPullRequestAnnotationItemViewModel>> AnnotationsDictionary { get; }
62+
IReadOnlyDictionary<string, IPullRequestAnnotationItemViewModel[]> AnnotationsDictionary { get; }
6363

6464
/// <summary>
6565
/// Initializes the view model.

0 commit comments

Comments
 (0)