Fixing other code analysis errors

Author: StanleyGoldman

src/GitHub.App/ViewModels/Dialog/ForkRepositoryExecuteViewModel.cs

@@ -94,7 +94,7 @@ IObservable<Repository> OnCreateFork(object o)
                     if (!ex.IsCriticalException())
                     {
                         log.Error(ex, "Error Creating Fork");
-                        var error = StandardUserErrors.GetUserFriendlyErrorMessage(ex, ErrorType.RepoForkFailed);
+                        var error = ex.GetUserFriendlyErrorMessage(ErrorType.RepoForkFailed);
                         notificationService.ShowError(error);
                     }
 

src/GitHub.App/ViewModels/Dialog/ForkRepositorySwitchViewModel.cs

@@ -20,8 +20,6 @@ namespace GitHub.ViewModels.Dialog
     [PartCreationPolicy(CreationPolicy.NonShared)]
     public class ForkRepositorySwitchViewModel : ViewModelBase, IForkRepositorySwitchViewModel
     {
-        static readonly ILogger log = LogManager.ForContext<ForkRepositorySwitchViewModel>();
-
         readonly IRepositoryForkService repositoryForkService;
 
         [ImportingConstructor]

src/GitHub.App/ViewModels/Dialog/ForkRepositoryViewModel.cs

@@ -15,15 +15,10 @@ namespace GitHub.ViewModels.Dialog
     [PartCreationPolicy(CreationPolicy.NonShared)]
     public class ForkRepositoryViewModel : PagedDialogViewModelBase, IForkRepositoryViewModel
     {
-        static readonly ILogger log = LogManager.ForContext<ForkRepositoryViewModel>();
-
         readonly IForkRepositorySelectViewModel selectPage;
         readonly IForkRepositorySwitchViewModel switchPage;
         readonly IForkRepositoryExecuteViewModel executePage;
 
-        ILocalRepositoryModel repository;
-        IConnection connection;
-
         [ImportingConstructor]
         public ForkRepositoryViewModel(
             IForkRepositorySelectViewModel selectPage,
@@ -40,27 +35,31 @@ public ForkRepositoryViewModel(
             selectPage.Done.Subscribe(x => ShowExecutePage((IAccount)x).Forget());
         }
 
+        public ILocalRepositoryModel Repository { get; private set; }
+
+        public IConnection Connection { get; private set; }
+
         private ReactiveCommand<object> Completed { get; }
 
         public override IObservable<object> Done => executePage.Done;
 
         public async Task InitializeAsync(ILocalRepositoryModel repository, IConnection connection)
         {
-            this.repository = repository;
-            this.connection = connection;
+            Repository = repository;
+            Connection = connection;
             await selectPage.InitializeAsync(repository, connection);
             Content = selectPage;
         }
 
         async Task ShowExecutePage(IAccount account)
         {
-            await executePage.InitializeAsync(repository, account, connection);
+            await executePage.InitializeAsync(Repository, account, Connection);
             Content = executePage;
         }
 
         void ShowSwitchRepositoryPath(IRemoteRepositoryModel remoteRepository)
         {
-            switchPage.Initialize(repository, remoteRepository);
+            switchPage.Initialize(Repository, remoteRepository);
             Content = switchPage;
         }
     }