Order comments when building comment threads.

grokys · grokys · commit 5ee352ac4199 · 2018-11-01T10:03:12.000+01:00
Looks like the API has started returning pending comments out of order, so order by `CreatedAt` client-side.
diff --git a/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs b/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
@@ -845,7 +845,7 @@ static void BuildPullRequestThreads(PullRequestDetailModel model)
             }
 
             // Get the comments that are replies and place them into the relevant list.
-            foreach (CommentAdapter comment in model.Reviews.SelectMany(x => x.Comments))
+            foreach (CommentAdapter comment in model.Reviews.SelectMany(x => x.Comments).OrderBy(x => x.CreatedAt))
             {
                 if (comment.ReplyTo != null)
                 {

Original file line number	Diff line number	Diff line change
`@@ -845,7 +845,7 @@ static void BuildPullRequestThreads(PullRequestDetailModel model)`
`845`	`845`	`}`
`846`	`846`
`847`	`847`	`// Get the comments that are replies and place them into the relevant list.`
`848`		`- foreach (CommentAdapter comment in model.Reviews.SelectMany(x => x.Comments))`
	`848`	`+ foreach (CommentAdapter comment in model.Reviews.SelectMany(x => x.Comments).OrderBy(x => x.CreatedAt))`
`849`	`849`	`{`
`850`	`850`	`if (comment.ReplyTo != null)`
`851`	`851`	`{`