Merge pull request #570 from github/fixes/551-link-to-button

Replace "Publish to GitHub" link button with button

Author: shana

src/GitHub.VisualStudio.UI/Resources.Designer.cs

@@ -333,8 +333,8 @@
   <data name="filterBranchesText" xml:space="preserve">
     <value>Filter branches</value>
   </data>
-  <data name="GetStartedLink" xml:space="preserve">
-    <value>Get Started</value>
+  <data name="PublishToGitHubButton" xml:space="preserve">
+    <value>Publish to GitHub</value>
   </data>
   <data name="GetStartedText" xml:space="preserve">
     <value>Get Started</value>

src/GitHub.VisualStudio.UI/Resources.resx

@@ -9,8 +9,7 @@
              mc:Ignorable="d"
              DataContext="{Binding ViewModel}" d:DesignWidth="230" d:DesignHeight="120"
              KeyboardNavigation.TabNavigation="Local"
-             Background="{DynamicResource GitHubVsToolWindowBackground}"
-  >
+             Background="{DynamicResource GitHubVsToolWindowBackground}">
 
     <UserControl.Style>
         <Style TargetType="{x:Type UserControl}">
@@ -30,6 +29,7 @@
                 <cache:SharedDictionaryManager Source="pack://application:,,,/GitHub.UI;component/SharedDictionary.xaml" />
             </ResourceDictionary.MergedDictionaries>
             <ui:BooleanToVisibilityConverter x:Key="BooleanToVisibilityConverter" />
+            <Style x:Key="VSStyledButton" BasedOn="{StaticResource VsButtonStyleKey}" TargetType="{x:Type Button}"/>
         </ResourceDictionary>
     </UserControl.Resources>
 
@@ -74,9 +74,7 @@
                    Foreground="{DynamicResource GitHubVsToolWindowText}" />
             <Button Grid.Column="2" KeyboardNavigation.TabIndex="1" Style="{StaticResource ActionLinkButton}" HorizontalAlignment="Left" x:Name="signup" Click="signup_Click" Content="{x:Static prop:Resources.SignUpLink}"
                     Visibility="{Binding ShowSignup, Converter={StaticResource BooleanToVisibilityConverter}}"/>
-            <Button Grid.Column="3" KeyboardNavigation.TabIndex="2" Style="{StaticResource ActionLinkButton}" HorizontalAlignment="Right" x:Name="connect" Click="connect_Click" Content="{x:Static prop:Resources.GetStartedLink}"
-                    Visibility="{Binding ShowGetStarted, Converter={StaticResource BooleanToVisibilityConverter}}"/>
-            <Rectangle Grid.Column="4" Width="16" Height="16" Margin="8,0,0,0" Fill="{StaticResource ConnectArrowBrush}"
+            <Button Grid.Column="3" KeyboardNavigation.TabIndex="2" Style="{StaticResource VSStyledButton}" HorizontalAlignment="Right" x:Name="connect" Click="connect_Click" Content="{x:Static prop:Resources.PublishToGitHubButton}"
                     Visibility="{Binding ShowGetStarted, Converter={StaticResource BooleanToVisibilityConverter}}"/>
         </Grid>