Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 613f30b

Browse files
committed
Remove the experimental EditorComments option
1 parent cd6b0e3 commit 613f30b

File tree

6 files changed

+0
-55
lines changed

6 files changed

+0
-55
lines changed

src/GitHub.Exports/Settings/generated/IPackageSettings.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@
77
"type": "bool",
88
"default": 'true'
99
},
10-
{
11-
"name": "EditorComments",
12-
"type": "bool",
13-
"default": "false"
14-
},
1510
{
1611
"name": "UIState",
1712
"type": "object",
@@ -40,7 +35,6 @@ public interface IPackageSettings : INotifyPropertyChanged
4035
{
4136
void Save();
4237
bool CollectMetrics { get; set; }
43-
bool EditorComments { get; set; }
4438
UIState UIState { get; set; }
4539
bool HideTeamExplorerWelcomeMessage { get; set; }
4640
bool EnableTraceLogging { get; set; }

src/GitHub.VisualStudio/Settings/OptionsPage.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,12 @@ protected override void OnActivate(CancelEventArgs e)
5151
void LoadSettings()
5252
{
5353
child.CollectMetrics = packageSettings.CollectMetrics;
54-
child.EditorComments = packageSettings.EditorComments;
5554
child.EnableTraceLogging = packageSettings.EnableTraceLogging;
5655
}
5756

5857
void SaveSettings()
5958
{
6059
packageSettings.CollectMetrics = child.CollectMetrics;
61-
packageSettings.EditorComments = child.EditorComments;
6260
packageSettings.EnableTraceLogging = child.EnableTraceLogging;
6361
packageSettings.Save();
6462
}

src/GitHub.VisualStudio/Settings/generated/PackageSettingsGen.cs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@
77
"type": "bool",
88
"default": 'true'
99
},
10-
{
11-
"name": "EditorComments",
12-
"type": "bool",
13-
"default": "false"
14-
},
1510
{
1611
"name": "UIState",
1712
"type": "object",
@@ -48,13 +43,6 @@ public bool CollectMetrics
4843
set { collectMetrics = value; this.RaisePropertyChange(); }
4944
}
5045

51-
bool editorComments;
52-
public bool EditorComments
53-
{
54-
get { return editorComments; }
55-
set { editorComments = value; this.RaisePropertyChange(); }
56-
}
57-
5846
bool forkButton;
5947
public bool ForkButton
6048
{
@@ -87,7 +75,6 @@ public bool EnableTraceLogging
8775
void LoadSettings()
8876
{
8977
CollectMetrics = (bool)settingsStore.Read("CollectMetrics", true);
90-
EditorComments = (bool)settingsStore.Read("EditorComments", false);
9178
UIState = SimpleJson.DeserializeObject<UIState>((string)settingsStore.Read("UIState", "{}"));
9279
HideTeamExplorerWelcomeMessage = (bool)settingsStore.Read("HideTeamExplorerWelcomeMessage", false);
9380
EnableTraceLogging = (bool)settingsStore.Read("EnableTraceLogging", false);
@@ -96,7 +83,6 @@ void LoadSettings()
9683
void SaveSettings()
9784
{
9885
settingsStore.Write("CollectMetrics", CollectMetrics);
99-
settingsStore.Write("EditorComments", EditorComments);
10086
settingsStore.Write("UIState", SimpleJson.SerializeObject(UIState));
10187
settingsStore.Write("HideTeamExplorerWelcomeMessage", HideTeamExplorerWelcomeMessage);
10288
settingsStore.Write("EnableTraceLogging", EnableTraceLogging);

src/GitHub.VisualStudio/UI/Settings/OptionsControl.xaml

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -95,27 +95,5 @@
9595
<CheckBox x:Name="chkEnableTraceLogging" VerticalAlignment="Center" Content="{x:Static ghfvs:Resources.Options_EnableTraceLoggingText}" />
9696
</DockPanel>
9797
</GroupBox>
98-
<GroupBox
99-
Margin="8,0,8,0"
100-
VerticalAlignment="Top"
101-
BorderBrush="LightGray"
102-
BorderThickness="1"
103-
Padding="6 8 6 8"
104-
Style="{DynamicResource GroupBoxFlat}">
105-
<GroupBox.Header>
106-
<Run Text="{x:Static ghfvs:Resources.Options_ExperimentalTitle}" />
107-
</GroupBox.Header>
108-
<DockPanel>
109-
<WrapPanel DockPanel.Dock="Top">
110-
<CheckBox x:Name="chkEditorComments" VerticalAlignment="Center" Content="{x:Static ghfvs:Resources.Options_EditorCommentsLabel}" />
111-
</WrapPanel>
112-
<TextBlock DockPanel.Dock="Bottom" TextWrapping="Wrap">
113-
<LineBreak />
114-
<Italic>
115-
<Run Text="{x:Static ghfvs:Resources.Options_ExperimentalNote}" />
116-
</Italic>
117-
</TextBlock>
118-
</DockPanel>
119-
</GroupBox>
12098
</StackPanel>
12199
</UserControl>

src/GitHub.VisualStudio/UI/Settings/OptionsControl.xaml.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@ public bool EnableTraceLogging
2525
set { chkEnableTraceLogging.IsChecked = value; }
2626
}
2727

28-
public bool EditorComments
29-
{
30-
get { return chkEditorComments.IsChecked ?? false; }
31-
set { chkEditorComments.IsChecked = value; }
32-
}
33-
3428
private void Hyperlink_RequestNavigate(object sender, System.Windows.Navigation.RequestNavigateEventArgs e)
3529
{
3630
var browser = VisualStudio.Services.DefaultExportProvider.GetExportedValue<IVisualStudioBrowser>();

src/common/settings.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,6 @@
55
"type": "bool",
66
"default": 'true'
77
},
8-
{
9-
"name": "EditorComments",
10-
"type": "bool",
11-
"default": "false"
12-
},
138
{
149
"name": "UIState",
1510
"type": "object",

0 commit comments

Comments
 (0)