Merge pull request #397 from github/fixes/tracking-collection-add-remove-should-throw

Tracking collection should throw some more

Author: grokys

src/GitHub.Exports.Reactive/Collections/TrackingCollection.cs

@@ -397,6 +397,8 @@ public IDisposable Subscribe(Action<T> onNext, Action onCompleted)
 
         public void AddItem(T item)
         {
+            if (source == null)
+                throw new InvalidOperationException("No source observable has been set. Call Listen or pass an observable to the constructor");
             if (disposed)
                 throw new ObjectDisposedException("TrackingCollection");
 
@@ -411,6 +413,8 @@ public void AddItem(T item)
 
         public void RemoveItem(T item)
         {
+            if (source == null)
+                throw new InvalidOperationException("No source observable has been set. Call Listen or pass an observable to the constructor");
             if (disposed)
                 throw new ObjectDisposedException("TrackingCollection");
 

src/TrackingCollectionTests/TrackingCollectionTests.cs

@@ -1943,4 +1943,18 @@ public void ListeningTwiceWorks()
 
         CollectionAssert.AreEqual(list2, col);
     }
+
+    [Test]
+    public void AddingWithNoObservableSetThrows()
+    {
+        ITrackingCollection<Thing> col = new TrackingCollection<Thing>();
+        Assert.Throws<InvalidOperationException>(() => col.AddItem(new Thing()));
+    }
+
+    [Test]
+    public void RemovingWithNoObservableSetThrows()
+    {
+        ITrackingCollection<Thing> col = new TrackingCollection<Thing>();
+        Assert.Throws<InvalidOperationException>(() => col.RemoveItem(new Thing()));
+    }
 }