Merge branch 'master' into fixes/1725-build-2017-target-2015

Author: jcansdale

appveyor.yml

@@ -1,4 +1,4 @@
-version: '2.5.3.{build}'
+version: '2.5.4.{build}'
 skip_tags: true
 install:
 - ps: |

src/CredentialManagement/CredentialManagement.csproj

@@ -9,6 +9,7 @@
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>CredentialManagement</RootNamespace>
     <AssemblyName>GitHub.CredentialManagement</AssemblyName>
+    <LangVersion>6</LangVersion>
     <TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>

src/GitHub.Api/GitHub.Api.csproj

@@ -9,6 +9,7 @@
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>GitHub.Api</RootNamespace>
     <AssemblyName>GitHub.Api</AssemblyName>
+    <LangVersion>6</LangVersion>
     <TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>

src/GitHub.App/GitHub.App.csproj

@@ -11,6 +11,7 @@
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>GitHub.App</RootNamespace>
     <AssemblyName>GitHub.App</AssemblyName>
+    <LangVersion>6</LangVersion>
     <TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>

src/GitHub.App/Services/GitClient.cs

@@ -96,20 +96,30 @@ public Task Fetch(IRepository repository, string remoteName)
 
         public Task Fetch(IRepository repo, UriString cloneUrl, params string[] refspecs)
         {
-            var httpsUrl = UriString.ToUriString(cloneUrl.ToRepositoryUrl());
+            var httpsString = cloneUrl.ToRepositoryUrl().ToString();
 
-            var originRemote = repo.Network.Remotes[defaultOriginName];
-            if (originRemote != null && originRemote.Url == httpsUrl)
+            foreach (var remote in repo.Network.Remotes)
             {
-                return Fetch(repo, defaultOriginName, refspecs);
+                var remoteUrl = new UriString(remote.Url);
+                if (!remoteUrl.IsHypertextTransferProtocol)
+                {
+                    // Only match http urls
+                    continue;
+                }
+
+                var remoteHttpsString = remoteUrl.ToRepositoryUrl().ToString();
+                if (remoteHttpsString.Equals(httpsString, StringComparison.OrdinalIgnoreCase))
+                {
+                    return Fetch(repo, defaultOriginName, refspecs);
+                }
             }
 
             return Task.Factory.StartNew(() =>
             {
                 try
                 {
                     var tempRemoteName = cloneUrl.Owner + "-" + Guid.NewGuid();
-                    var remote = repo.Network.Remotes.Add(tempRemoteName, httpsUrl);
+                    var remote = repo.Network.Remotes.Add(tempRemoteName, httpsString);
                     try
                     {
 #pragma warning disable 0618 // TODO: Replace `Network.Fetch` with `Commands.Fetch`.

src/GitHub.App/Services/PullRequestService.cs

@@ -150,25 +150,40 @@ public IObservable<bool> IsWorkingDirectoryClean(ILocalRepositoryModel repositor
             using (var repo = gitService.GetRepository(repository.LocalPath))
             {
                 var statusOptions = new StatusOptions { ExcludeSubmodules = true };
-                var isClean = !IsFilthy(repo.RetrieveStatus(statusOptions));
+                var status = repo.RetrieveStatus(statusOptions);
+                var isClean = !IsCheckoutBlockingDirty(status);
                 return Observable.Return(isClean);
             }
         }
 
-        static bool IsFilthy(RepositoryStatus status)
+        static bool IsCheckoutBlockingDirty(RepositoryStatus status)
         {
             if (status.IsDirty)
             {
-                // This is similar to IsDirty, but also allows NewInWorkdir files
-                return status.Any(entry =>
-                    entry.State != FileStatus.Ignored &&
-                    entry.State != FileStatus.Unaltered &&
-                    entry.State != FileStatus.NewInWorkdir);
+                return status.Any(entry => IsCheckoutBlockingChange(entry));
             }
 
             return false;
         }
 
+        // This is similar to IsDirty, but also allows NewInWorkdir and DeletedFromWorkdir files
+        static bool IsCheckoutBlockingChange(StatusEntry entry)
+        {
+            switch (entry.State)
+            {
+                case FileStatus.Ignored:
+                    return false;
+                case FileStatus.Unaltered:
+                    return false;
+                case FileStatus.NewInWorkdir:
+                    return false;
+                case FileStatus.DeletedFromWorkdir:
+                    return false;
+                default:
+                    return true;
+            }
+        }
+
         public IObservable<Unit> Pull(ILocalRepositoryModel repository)
         {
             return Observable.Defer(async () =>

src/GitHub.Exports.Reactive/GitHub.Exports.Reactive.csproj

@@ -10,6 +10,7 @@
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>GitHub</RootNamespace>
     <AssemblyName>GitHub.Exports.Reactive</AssemblyName>
+    <LangVersion>6</LangVersion>
     <TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>

src/GitHub.Exports.Reactive/Services/IPullRequestSession.cs

@@ -109,12 +109,10 @@ Task<IPullRequestReviewCommentModel> PostReviewComment(
         /// Posts a PR review comment reply.
         /// </summary>
         /// <param name="body">The comment body.</param>
-        /// <param name="inReplyTo">The REST ID of the comment to reply to.</param>
         /// <param name="inReplyToNodeId">The GraphQL ID of the comment to reply to.</param>
         /// <returns>A comment model.</returns>
         Task<IPullRequestReviewCommentModel> PostReviewComment(
             string body,
-            int inReplyTo,
             string inReplyToNodeId);
 
         /// <summary>

src/GitHub.Exports/GitHub.Exports.csproj

@@ -10,6 +10,7 @@
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>GitHub</RootNamespace>
     <AssemblyName>GitHub.Exports</AssemblyName>
+    <LangVersion>6</LangVersion>
     <TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>

src/GitHub.Extensions.Reactive/GitHub.Extensions.Reactive.csproj

@@ -9,6 +9,7 @@
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>GitHub.Extensions.Reactive</RootNamespace>
     <AssemblyName>GitHub.Extensions.Reactive</AssemblyName>
+    <LangVersion>6</LangVersion>
     <TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>