Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 67a8a8c

Browse files
committed
Doc fixes.
1 parent 1c24639 commit 67a8a8c

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

docs/developer/how-viewmodels-are-turned-into-views.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ One can choose to display the `ViewModel` instance in any way we want by using a
5656

5757
</DataTemplate>
5858
</Window.Resources>
59-
</pfui:DialogWindow>
59+
</Window>
6060
```
6161

6262
This is the basis for converting view models to views.

docs/developer/implementing-a-dialog-view.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ GitHub for Visual Studio has a common dialog which is used to show the login, cl
44

55
## Create a View Model and Interface
66

7-
> TODO: `NewViewModelBase` will become simply `ViewModelBase` once the MVVM refactor is completed.
8-
97
- Create an interface for the view model that implements `IDialogContentViewModel` in `GitHub.Exports.Reactive\ViewModels\Dialog`
108
- Create a view model that inherits from `NewViewModelBase` and implements the interface in `GitHub.App\ViewModels\Dialog`
119
- Export the view model with the interface as the contract and add a `[PartCreationPolicy(CreationPolicy.NonShared)]` attribute
@@ -34,7 +32,7 @@ namespace GitHub.ViewModels.Dialog
3432
{
3533
[Export(typeof(IExampleDialogViewModel))]
3634
[PartCreationPolicy(CreationPolicy.NonShared)]
37-
public class ExampleDialogViewModel : NewViewModelBase, IExampleDialogViewModel
35+
public class ExampleDialogViewModel : ViewModelBase, IExampleDialogViewModel
3836
{
3937
[ImportingConstructor]
4038
public ExampleDialogViewModel()
@@ -53,8 +51,6 @@ namespace GitHub.ViewModels.Dialog
5351

5452
## Create a View
5553

56-
> TODO: Decide if `GitHub.VisualStudio\Views` is the best place for views
57-
5854
- Create a WPF `UserControl` under `GitHub.VisualStudio\Views\Dialog`
5955
- Add an `ExportViewFor` attribute with the type of the view model interface
6056
- Add a `PartCreationPolicy(CreationPolicy.NonShared)]` attribute
@@ -93,7 +89,7 @@ namespace GitHub.VisualStudio.Views.Dialog
9389

9490
## Show the Dialog!
9591

96-
To show the dialog you will need an instance of the `IShowDialog` service. Once you have that, simply call the `Show` method with an instance of your view model.
92+
To show the dialog you will need an instance of the `IShowDialogService` service. Once you have that, simply call the `Show` method with an instance of your view model.
9793

9894
```csharp
9995
var viewModel = new ExampleDialogViewModel();

0 commit comments

Comments
 (0)