Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 69a88c6

Browse files
committed
Trim project references to GitHub.VisualStudio
The only test project that should reference GitHub.VisualStudio is GitHub.VisualStudio.UnitTests.
1 parent 24b03a3 commit 69a88c6

File tree

7 files changed

+4
-28
lines changed

7 files changed

+4
-28
lines changed

test/GitHub.Api.UnitTests/GitHub.Api.UnitTests.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,6 @@
113113
<Project>{7f5ed78b-74a3-4406-a299-70cfb5885b8b}</Project>
114114
<Name>GitHub.InlineReviews</Name>
115115
</ProjectReference>
116-
<ProjectReference Include="..\..\src\GitHub.VisualStudio\GitHub.VisualStudio.csproj">
117-
<Project>{11569514-5ae5-4b5b-92a2-f10b0967de5f}</Project>
118-
<Name>GitHub.VisualStudio</Name>
119-
</ProjectReference>
120116
</ItemGroup>
121117
<ItemGroup>
122118
<None Include="packages.config">

test/GitHub.Api.UnitTests/SimpleApiClientFactoryTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
using GitHub.Api;
44
using GitHub.Primitives;
55
using GitHub.Services;
6-
using GitHub.VisualStudio;
6+
using GitHub.Models;
77
using NSubstitute;
88
using Octokit;
99
using NUnit.Framework;
@@ -16,7 +16,7 @@ public class TheCreateMethod
1616
public async Task CreatesNewInstanceOfSimpleApiClient()
1717
{
1818
const string url = "https://github.com/github/CreatesNewInstanceOfSimpleApiClient";
19-
var program = new Program();
19+
var program = Substitute.For<IProgram>();
2020
var keychain = Substitute.For<IKeychain>();
2121
var enterpriseProbe = Substitute.For<IEnterpriseProbe>();
2222
var wikiProbe = Substitute.For<IWikiProbe>();
@@ -30,7 +30,7 @@ public async Task CreatesNewInstanceOfSimpleApiClient()
3030

3131
Assert.That(url, Is.EqualTo(client.OriginalUrl));
3232
Assert.That(HostAddress.GitHubDotComHostAddress, Is.EqualTo(client.HostAddress));
33-
Assert.That(client,Is.SameAs(await factory.Create(url))); // Tests caching.
33+
Assert.That(client, Is.SameAs(await factory.Create(url))); // Tests caching.
3434
}
3535
}
3636

@@ -40,7 +40,7 @@ public class TheClearFromCacheMethod
4040
public async Task RemovesClientFromCache()
4141
{
4242
const string url = "https://github.com/github/RemovesClientFromCache";
43-
var program = new Program();
43+
var program = Substitute.For<IProgram>();
4444
var enterpriseProbe = Substitute.For<IEnterpriseProbe>();
4545
var wikiProbe = Substitute.For<IWikiProbe>();
4646
var factory = new SimpleApiClientFactory(

test/GitHub.Exports.Reactive.UnitTests/GitHub.Exports.Reactive.UnitTests.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -207,10 +207,6 @@
207207
<Project>{7f5ed78b-74a3-4406-a299-70cfb5885b8b}</Project>
208208
<Name>GitHub.InlineReviews</Name>
209209
</ProjectReference>
210-
<ProjectReference Include="..\..\src\GitHub.VisualStudio\GitHub.VisualStudio.csproj">
211-
<Project>{11569514-5ae5-4b5b-92a2-f10b0967de5f}</Project>
212-
<Name>GitHub.VisualStudio</Name>
213-
</ProjectReference>
214210
</ItemGroup>
215211
<Import Project="$(VSToolsPath)\TeamTest\Microsoft.TestTools.targets" Condition="Exists('$(VSToolsPath)\TeamTest\Microsoft.TestTools.targets')" />
216212
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />

test/GitHub.Extensions.UnitTests/GitHub.Extensions.UnitTests.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,6 @@
109109
<Project>{7f5ed78b-74a3-4406-a299-70cfb5885b8b}</Project>
110110
<Name>GitHub.InlineReviews</Name>
111111
</ProjectReference>
112-
<ProjectReference Include="..\..\src\GitHub.VisualStudio\GitHub.VisualStudio.csproj">
113-
<Project>{11569514-5ae5-4b5b-92a2-f10b0967de5f}</Project>
114-
<Name>GitHub.VisualStudio</Name>
115-
</ProjectReference>
116112
</ItemGroup>
117113
<ItemGroup>
118114
<None Include="packages.config">

test/GitHub.Primitives.UnitTests/GitHub.Primitives.UnitTests.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,6 @@
101101
<Project>{7f5ed78b-74a3-4406-a299-70cfb5885b8b}</Project>
102102
<Name>GitHub.InlineReviews</Name>
103103
</ProjectReference>
104-
<ProjectReference Include="..\..\src\GitHub.VisualStudio\GitHub.VisualStudio.csproj">
105-
<Project>{11569514-5ae5-4b5b-92a2-f10b0967de5f}</Project>
106-
<Name>GitHub.VisualStudio</Name>
107-
</ProjectReference>
108104
</ItemGroup>
109105
<ItemGroup>
110106
<None Include="packages.config">

test/GitHub.TeamFoundation.UnitTests/GitHub.TeamFoundation.UnitTests.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -199,10 +199,6 @@
199199
<Project>{161DBF01-1DBF-4B00-8551-C5C00F26720D}</Project>
200200
<Name>GitHub.TeamFoundation.14</Name>
201201
</ProjectReference>
202-
<ProjectReference Include="..\..\src\GitHub.VisualStudio\GitHub.VisualStudio.csproj">
203-
<Project>{11569514-5ae5-4b5b-92a2-f10b0967de5f}</Project>
204-
<Name>GitHub.VisualStudio</Name>
205-
</ProjectReference>
206202
</ItemGroup>
207203
<ItemGroup>
208204
<None Include="packages.config">

test/GitHub.UI.UnitTests/GitHub.UI.UnitTests.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,6 @@
9393
<Project>{346384dd-2445-4a28-af22-b45f3957bd89}</Project>
9494
<Name>GitHub.UI</Name>
9595
</ProjectReference>
96-
<ProjectReference Include="..\..\src\GitHub.VisualStudio\GitHub.VisualStudio.csproj">
97-
<Project>{11569514-5ae5-4b5b-92a2-f10b0967de5f}</Project>
98-
<Name>GitHub.VisualStudio</Name>
99-
</ProjectReference>
10096
</ItemGroup>
10197
<ItemGroup>
10298
<Page Include="Helpers\SharedDictionary.xaml">

0 commit comments

Comments
 (0)