Don't give up if submodule init or update fails

jcansdale · jcansdale · commit 6a7c76df21cf · 2018-02-07T14:33:56.000Z
diff --git a/src/GitHub.App/Services/PullRequestService.cs b/src/GitHub.App/Services/PullRequestService.cs
@@ -219,7 +219,7 @@ public IObservable<Unit> SyncSubmodules(ILocalRepositoryModel repository)
         // LibGit2Sharp has limited submodule support so shelling out Git.exe for submodule commands.
         async Task<int> SyncSubmodules(string workingDir, Action<string> progress = null)
         {
-            var cmdArguments = "/C git submodule init && git submodule sync --recursive && git submodule update --recursive";
+            var cmdArguments = "/C git submodule init & git submodule sync --recursive & git submodule update --recursive";
             var startInfo = new ProcessStartInfo("cmd", cmdArguments)
             {
                 WorkingDirectory = workingDir,

Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,7 @@ public IObservable<Unit> SyncSubmodules(ILocalRepositoryModel repository)`
`219`	`219`	`// LibGit2Sharp has limited submodule support so shelling out Git.exe for submodule commands.`
`220`	`220`	`async Task<int> SyncSubmodules(string workingDir, Action<string> progress = null)`
`221`	`221`	`{`
`222`		`- var cmdArguments = "/C git submodule init && git submodule sync --recursive && git submodule update --recursive";`
	`222`	`+ var cmdArguments = "/C git submodule init & git submodule sync --recursive & git submodule update --recursive";`
`223`	`223`	`var startInfo = new ProcessStartInfo("cmd", cmdArguments)`
`224`	`224`	`{`
`225`	`225`	`WorkingDirectory = workingDir,`