Add alternate ApiClientConfiguration file for public users

Author: shana

src/GitHub.App/Api/ApiClient.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Globalization;
 using System.Linq;
 using System.Net;
@@ -17,13 +17,11 @@
 
 namespace GitHub.Api
 {
-    public class ApiClient : IApiClient
+    public partial class ApiClient : IApiClient
     {
         static readonly Logger log = LogManager.GetCurrentClassLogger();
 
         const string ProductName = Info.ApplicationInfo.ApplicationDescription;
-        const string clientId = "";
-        const string clientSecret = "";
 
         readonly IObservableGitHubClient gitHubClient;
         // There are two sets of authorization scopes, old and new:
@@ -34,12 +32,18 @@ public class ApiClient : IApiClient
         readonly static Lazy<string> lazyNote = new Lazy<string>(() => ProductName + " on " + GetMachineNameSafe());
         readonly static Lazy<string> lazyFingerprint = new Lazy<string>(GetFingerprint);
 
+        string ClientId { get; set; }
+        string ClientSecret { get; set; }
+
         public ApiClient(HostAddress hostAddress, IObservableGitHubClient gitHubClient)
         {
+            Configure();
             HostAddress = hostAddress;
             this.gitHubClient = gitHubClient;
         }
 
+        partial void Configure();
+
         public IObservable<Repository> CreateRepository(NewRepository repository, string login, bool isUser)
         {
             Guard.ArgumentNotEmptyString(login, "login");
@@ -76,14 +80,14 @@ public IObservable<ApplicationAuthorization> GetOrCreateApplicationAuthenticatio
 
             return string.IsNullOrEmpty(authenticationCode)
                 ? authorizationsClient.CreateAndDeleteExistingApplicationAuthorization(
-                        clientId,
-                        clientSecret,
+                        ClientId,
+                        ClientSecret,
                         newAuthorization,
                         dispatchedHandler,
                         true)
                 :   authorizationsClient.CreateAndDeleteExistingApplicationAuthorization(
-                        clientId,
-                        clientSecret,
+                        ClientId,
+                        ClientSecret,
                         newAuthorization,
                         dispatchedHandler,
                         authenticationCode,
@@ -116,7 +120,7 @@ public IObservable<LicenseMetadata> GetLicenses()
             return gitHubClient.Miscellaneous.GetAllLicenses();
         }
 
-        public HostAddress HostAddress { get; private set; }
+        public HostAddress HostAddress { get; }
 
         public ITwoFactorChallengeHandler TwoFactorChallengeHandler { get; private set; }
 

src/GitHub.App/Api/ApiClientConfiguration.cs

@@ -0,0 +1,14 @@
+namespace GitHub.Api
+{
+    public partial class ApiClient : IApiClient
+    {
+        const string clientId = "YOUR CLIENT ID HERE";
+        const string clientSecret = "YOUR CLIENT SECRET HERE";
+
+        partial void Configure()
+        {
+            ClientId = clientId;
+            ClientSecret = clientSecret;
+        }
+    }
+}

src/GitHub.App/GitHub.App.csproj

@@ -18,6 +18,7 @@
     <RunCodeAnalysis>true</RunCodeAnalysis>
     <CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <BuildType Condition="Exists('..\..\script\ApiClientConfiguration.cs')">Internal</BuildType>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <DebugSymbols>true</DebugSymbols>
@@ -135,6 +136,10 @@
     <Compile Include="..\common\SolutionInfo.cs">
       <Link>Properties\SolutionInfo.cs</Link>
     </Compile>
+    <Compile Include="..\..\script\ApiClientConfiguration.cs" Condition="$(Buildtype) == 'Internal'">
+      <Link>Api\ApiClientConfiguration.cs</Link>
+    </Compile>
+    <Compile Include="Api\ApiClientConfiguration.cs" Condition="$(Buildtype) != 'Internal'" />
   </ItemGroup>
   <ItemGroup>
     <None Include="AkavacheSqliteLinkerOverride.cs" />