Use Forget to log any exceptions

Author: jcansdale

src/GitHub.InlineReviews/Services/PullRequestStatusBarManager.cs

@@ -72,7 +72,7 @@ public void StartShowingStatus()
                     .CombineLatest(sessions, (r, s) => (r, s))
                     .Throttle(TimeSpan.FromSeconds(1))
                     .ObserveOn(RxApp.MainThreadScheduler)
-                    .Subscribe(x => RefreshCurrentSession(x.r, x.s).Forget());
+                    .Subscribe(x => RefreshCurrentSession(x.r, x.s).Forget(log));
             }
             catch (Exception e)
             {
@@ -82,22 +82,15 @@ public void StartShowingStatus()
 
         async Task RefreshCurrentSession(ILocalRepositoryModel repository, IPullRequestSession session)
         {
-            try
-            {
-                var showStatus = await IsDotComOrEnterpriseRepository(repository);
-                if (!showStatus)
-                {
-                    ShowStatus(null);
-                    return;
-                }
-
-                var viewModel = CreatePullRequestStatusViewModel(session);
-                ShowStatus(viewModel);
-            }
-            catch (Exception e)
+            var showStatus = await IsDotComOrEnterpriseRepository(repository);
+            if (!showStatus)
             {
-                log.Error(e, nameof(RefreshCurrentSession));
+                ShowStatus(null);
+                return;
             }
+
+            var viewModel = CreatePullRequestStatusViewModel(session);
+            ShowStatus(viewModel);
         }
 
         async Task<bool> IsDotComOrEnterpriseRepository(ILocalRepositoryModel repository)