Removing status and check avatars

Author: StanleyGoldman

src/GitHub.App/SampleData/PullRequestCheckViewModelDesigner.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Reactive;
-using System.Windows.Media.Imaging;
 using GitHub.Models;
 using GitHub.ViewModels;
 using GitHub.ViewModels.GitHubPane;
@@ -18,10 +17,6 @@ public sealed class PullRequestCheckViewModelDesigner : ViewModelBase, IPullRequ
 
         public Uri DetailsUrl { get; set; } = new Uri("http://github.com");
 
-        public string AvatarUrl { get; set; } = "https://avatars1.githubusercontent.com/u/417571?s=88&v=4";
-
-        public BitmapImage Avatar { get; set; } = null;
-
         public ReactiveCommand<Unit, Unit> OpenDetailsUrl { get; set; } = null;
 
         public PullRequestCheckType CheckType { get; set; } = PullRequestCheckType.ChecksApi;

src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs

@@ -4,10 +4,10 @@
 using System.Linq;
 using System.Linq.Expressions;
 using System.Reactive;
-using System.Windows.Media.Imaging;
 using GitHub.Extensions;
 using GitHub.Factories;
 using GitHub.Models;
+using GitHub.Primitives;
 using GitHub.Services;
 using ReactiveUI;
 
@@ -55,10 +55,6 @@ public static IEnumerable<IPullRequestCheckViewModel> Build(IViewViewModelFactor
                 pullRequestCheckViewModel.Description = statusModel.Description;
                 pullRequestCheckViewModel.Status = checkStatus;
                 pullRequestCheckViewModel.DetailsUrl = !string.IsNullOrEmpty(statusModel.TargetUrl) ? new Uri(statusModel.TargetUrl) : null;
-                pullRequestCheckViewModel.AvatarUrl = statusModel.AvatarUrl ?? DefaultAvatar;
-                pullRequestCheckViewModel.Avatar = statusModel.AvatarUrl != null
-                    ? new BitmapImage(new Uri(statusModel.AvatarUrl))
-                    : AvatarProvider.CreateBitmapImage(DefaultAvatar);
 
                 return pullRequestCheckViewModel;
             }) ?? Array.Empty<PullRequestCheckViewModel>();
@@ -110,9 +106,6 @@ public static IEnumerable<IPullRequestCheckViewModel> Build(IViewViewModelFactor
                     pullRequestCheckViewModel.Description = arg.checkRun.Summary;
                     pullRequestCheckViewModel.Status = checkStatus;
                     pullRequestCheckViewModel.DetailsUrl = new Uri(arg.checkRun.DetailsUrl);
-                    pullRequestCheckViewModel.AvatarUrl = DefaultAvatar;
-                    pullRequestCheckViewModel.Avatar = AvatarProvider.CreateBitmapImage(DefaultAvatar);
-
                     return pullRequestCheckViewModel;
                 }) ?? Array.Empty<PullRequestCheckViewModel>();
 
@@ -168,9 +161,5 @@ private void DoOpenDetailsUrl()
 
         /// <inheritdoc/>
         public ReactiveCommand<Unit, Unit> OpenDetailsUrl { get; }
-
-        public string AvatarUrl { get; private set; }
-
-        public BitmapImage Avatar { get; private set; }
     }
 }

src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestCheckViewModel.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Reactive;
-using System.Windows.Media.Imaging;
 using GitHub.Models;
 using ReactiveUI;
 
@@ -50,10 +49,6 @@ public interface IPullRequestCheckViewModel: IViewModel
         /// Gets a flag to show this check run has annotations.
         /// </summary>
         bool HasAnnotations { get; }
-
-        string AvatarUrl { get; }
-
-        BitmapImage Avatar { get; }
     }
 
     public enum PullRequestCheckStatus

src/GitHub.Exports/Models/CheckSuiteModel.cs

@@ -20,6 +20,5 @@ public class CheckSuiteModel
 
         public string ApplicationName { get; set; }
         public string ApplicationSlug { get; set; }
-        public string ApplicationLogoUrl { get; set; }
     }
 }

src/GitHub.Exports/Models/StatusModel.cs

@@ -24,10 +24,5 @@ public class StatusModel
         /// The descritption for the Status
         /// </summary>
         public string Description { get; set; }
-
-        /// <summary>
-        /// The avatar url of the Status.
-        /// </summary>
-        public string AvatarUrl { get; set; }
     }
 }

src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

@@ -810,8 +810,7 @@ async Task<LastCommitAdapter> GetPullRequestLastCommitAdapter(HostAddress addres
                                                       }).ToList()
                                               }).ToList(),
                                           ApplicationName = suite.App != null ? suite.App.Name : "Private App",
-                                          ApplicationSlug = suite.App != null ? suite.App.Slug : "private-app",
-                                          ApplicationLogoUrl = suite.App != null ? suite.App.LogoUrl(null) : null,
+                                          ApplicationSlug = suite.App != null ? suite.App.Slug : "private-app"
                                       }).ToList(),
                                   Statuses = commit.Commit.Status
                                       .Select(context =>
@@ -820,8 +819,7 @@ async Task<LastCommitAdapter> GetPullRequestLastCommitAdapter(HostAddress addres
                                               State = statusContext.State.FromGraphQl(),
                                               Context = statusContext.Context,
                                               TargetUrl = statusContext.TargetUrl,
-                                              Description = statusContext.Description,
-                                              AvatarUrl = statusContext.Creator.AvatarUrl(null)
+                                              Description = statusContext.Description
                                           }).ToList()
                                       ).SingleOrDefault()
                               }

src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestCheckView.xaml

@@ -39,7 +39,11 @@
         <ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="check" Foreground="#2cbe4e" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
         <ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="x" Foreground="#cb2431" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
         <ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="primitive_dot" Foreground="#f1c647" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
-        <Image Grid.Column="1" Source="{Binding Avatar}" Height="16" Width="16" />
+
+	<!--
+        <Image Grid.Column="1" Source="{Binding AvatarUrl}" Height="16" Width="16" />
+        -->
+
         <Label Grid.Column="2" Foreground="{DynamicResource VsBrush.WindowText}" Content="{Binding Title}"/>
         <!--
             <Label Grid.Column="3" HorizontalAlignment="Right" Content="{Binding Description}" ToolTip="{Binding Description}" />