Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 7597499

Browse files
authored
Implement stubs in status bar service
The new methods are not meaningful for the status bar, we're not tracking shown messages and the status bar only shows text, so there's no meaningful implementation (and no need to throw)
1 parent 7b6af4e commit 7597499

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/GitHub.Exports/Services/StatusBarNotificationService.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,13 @@ public StatusBarNotificationService([Import(typeof(SVsServiceProvider))] IServic
2222

2323
public void HideNotification(Guid guid)
2424
{
25-
throw new NotImplementedException();
25+
// status bar only shows text, this is a noop
2626
}
2727

2828
public bool IsNotificationVisible(Guid guid)
2929
{
30-
throw new NotImplementedException();
30+
// it's only text, there's no way of checking
31+
return false;
3132
}
3233

3334
public void ShowError(string message)

0 commit comments

Comments
 (0)