Remove dependency on versioning.targets

Author: jcansdale

src/GitHub.Exports/Settings/ExtensionInformation.cs

@@ -0,0 +1,9 @@
+namespace GitHub.Settings
+{
+    public static class AssemblyVersionInformation
+    {
+        // HACK: For some reason ThisAssembly.AssemblyFileVersion can't be referenced
+        // directly from inside GitHub.VisualStudio.
+        public const string Version = ThisAssembly.AssemblyFileVersion;
+    }
+}

src/GitHub.VisualStudio.Vsix/GitHub.VisualStudio.Vsix.csproj

@@ -357,7 +357,6 @@
   <Import Project="packaging.targets" />
   <!-- For regenerating templates on build -->
   <Import Project="..\common\t4.targets" />
-  <Import Project="versioning.targets" />
   <!--
     This is a workaround for allowing neutral CTO resource produced from *.vsct to go in the main assembly.
     We move the neutral *.cto file to be categorized as WithCulture=true,Culture=en to prevent the tools from falsely reporting:

src/GitHub.VisualStudio.Vsix/versioning.targets

@@ -318,7 +318,6 @@
   <Import Project="packaging.targets" />
   <!-- For regenerating templates on build -->
   <Import Project="..\common\t4.targets" />
-  <Import Project="versioning.targets" />
   <!--
     This is a workaround for allowing neutral CTO resource produced from *.vsct to go in the main assembly.
     We move the neutral *.cto file to be categorized as WithCulture=true,Culture=en to prevent the tools from falsely reporting:

src/GitHub.VisualStudio/GitHub.VisualStudio.csproj

@@ -35,7 +35,7 @@
 namespace GitHub.VisualStudio
 {
     [PackageRegistration(UseManagedResourcesOnly = true, AllowsBackgroundLoading = true)]
-    [InstalledProductRegistration("#110", "#112", AssemblyVersionInformation.Version)]
+    [InstalledProductRegistration("#110", "#112", ExtensionInformation.Version)]
     [Guid(Guids.guidGitHubPkgString)]
     [ProvideMenuResource("Menus.ctmenu", 1)]
     [ProvideAutoLoad(Guids.GitContextPkgString, PackageAutoLoadFlags.BackgroundLoad)]

src/GitHub.VisualStudio/GitHubPackage.cs

@@ -171,7 +171,7 @@ async Task<UsageModel> GetCurrentReport(UsageData data)
             current.Dimensions.Lang = CultureInfo.InstalledUICulture.IetfLanguageTag;
             current.Dimensions.CurrentLang = CultureInfo.CurrentCulture.IetfLanguageTag;
             current.Dimensions.CurrentUILang = CultureInfo.CurrentUICulture.IetfLanguageTag;
-            current.Dimensions.AppVersion = AssemblyVersionInformation.Version;
+            current.Dimensions.AppVersion = ExtensionInformation.Version;
             current.Dimensions.VSVersion = vsservices.VSVersion;
 
             current.Dimensions.IsGitHubUser = IsGitHubUser;

src/GitHub.VisualStudio/Services/UsageTracker.cs

@@ -1,23 +1,12 @@
-using System;
 using System.Reflection;
 using System.Resources;
 using System.Runtime.InteropServices;
 
 [assembly: AssemblyProduct("GitHub Extension for Visual Studio")]
-[assembly: AssemblyVersion(AssemblyVersionInformation.Version)]
-[assembly: AssemblyFileVersion(AssemblyVersionInformation.Version)]
-[assembly: AssemblyInformationalVersion(AssemblyVersionInformation.Version)]
 [assembly: ComVisible(false)]
 [assembly: AssemblyCompany("GitHub, Inc.")]
 [assembly: AssemblyCopyright("Copyright © GitHub, Inc. 2014-2016")]
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 [assembly: NeutralResourcesLanguage("en-US")]
-
-namespace System
-{
-    internal static class AssemblyVersionInformation {
-        internal const string Version = "2.10.8.0";
-    }
-}

src/GitHub.VisualStudio/versioning.targets

@@ -18,19 +18,3 @@
 // to COM components.  If you need to access a type in this assembly from
 // COM, set the ComVisible attribute to true on that type.
 [assembly: ComVisible(false)]
-
-// The following GUID is for the ID of the typelib if this project is exposed to COM
-[assembly: Guid("14fdee91-7301-4247-846c-049647bf8e99")]
-
-// Version information for an assembly consists of the following four values:
-//
-//      Major Version
-//      Minor Version
-//      Build Number
-//      Revision
-//
-// You can specify all the values or you can default the Build and Revision Numbers
-// by using the '*' as shown below:
-// [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.0.0")]
-[assembly: AssemblyFileVersion("1.0.0.0")]

src/common/SolutionInfo.cs

@@ -18,19 +18,3 @@
 // to COM components.  If you need to access a type in this assembly from
 // COM, set the ComVisible attribute to true on that type.
 [assembly: ComVisible(false)]
-
-// The following GUID is for the ID of the typelib if this project is exposed to COM
-[assembly: Guid("09313e65-7adb-48c1-ad3a-572020c5bdcb")]
-
-// Version information for an assembly consists of the following four values:
-//
-//      Major Version
-//      Minor Version
-//      Build Number
-//      Revision
-//
-// You can specify all the values or you can default the Build and Revision Numbers
-// by using the '*' as shown below:
-// [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.0.0")]
-[assembly: AssemblyFileVersion("1.0.0.0")]