Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 79dd24a

Browse files
Steven Kirkpaladique
authored andcommitted
Update logged metrics.
Now logging check outs, pulls and pushes of PR branches, both local and remote.
1 parent 20cef21 commit 79dd24a

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/GitHub.App/ViewModels/PullRequestDetailViewModel.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,10 @@ public async Task Load(IPullRequestModel pullRequest)
288288
{
289289
Model = pullRequest;
290290
Title = Resources.PullRequestNavigationItemText + " #" + pullRequest.Number;
291+
SourceBranchDisplayName = GetBranchDisplayName(pullRequest.Head?.Label);
292+
TargetBranchDisplayName = GetBranchDisplayName(pullRequest.Base.Label);
293+
IsFromFork = pullRequestsService.IsPullRequestFromFork(repository, pullRequest);
294+
Body = !string.IsNullOrWhiteSpace(pullRequest.Body) ? pullRequest.Body : "*No description provided.*";
291295

292296
IsFromFork = pullRequestsService.IsPullRequestFromFork(repository, Model);
293297
SourceBranchDisplayName = GetBranchDisplayName(IsFromFork, pullRequest.Head?.Label);
@@ -483,7 +487,7 @@ IObservable<Unit> DoCheckout(object unused)
483487
{
484488
var localBranches = await pullRequestsService.GetLocalBranches(repository, Model).ToList();
485489

486-
usageTracker.IncrementPullRequestCheckedOut().Forget();
490+
usageTracker.IncrementPullRequestCheckOutCount(IsFromFork).Forget();
487491

488492
if (localBranches.Count > 0)
489493
{

src/GitHub.VisualStudio/Services/UsageTracker.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -360,8 +360,6 @@ static void ClearCounters(UsageModel usage, bool weekly, bool monthly)
360360
usage.NumberOfForkPullRequestsCheckedOut = 0;
361361
usage.NumberOfForkPullRequestPulls = 0;
362362
usage.NumberOfForkPullRequestPushes = 0;
363-
usage.NumberOfPullRequestsOpened = 0;
364-
usage.NumberOfPullRequestsCheckedOut = 0;
365363

366364
if (weekly)
367365
usage.NumberOfStartupsWeek = 0;

src/GitHub.VisualStudio/Services/UsageTrackerDispatcher.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,5 @@ public UsageTrackerDispatcher([Import(typeof(SVsServiceProvider))] IServiceProvi
3232
public Task IncrementWelcomeDocsClicks() => inner.IncrementWelcomeDocsClicks();
3333
public Task IncrementWelcomeTrainingClicks() => inner.IncrementWelcomeTrainingClicks();
3434
public Task IncrementGitHubPaneHelpClicks() => inner.IncrementGitHubPaneHelpClicks();
35-
public Task IncrementPullRequestOpened() => inner.IncrementPullRequestOpened();
36-
public Task IncrementPullRequestCheckedOut() => inner.IncrementPullRequestCheckedOut();
3735
}
3836
}

0 commit comments

Comments
 (0)